From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14008 invoked by alias); 17 Feb 2015 11:32:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13998 invoked by uid 89); 17 Feb 2015 11:32:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Feb 2015 11:32:55 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1HBWq45010828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 17 Feb 2015 06:32:52 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1HBWoGf005284; Tue, 17 Feb 2015 06:32:51 -0500 Message-ID: <54E326E2.805@redhat.com> Date: Tue, 17 Feb 2015 11:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sergio Durigan Junior , "Jose E. Marchesi" CC: gdb-patches@sourceware.org Subject: Re: [PATCH V4 7/9] Simple testsuite for DTrace USDT probes. References: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> <1422874968-382-8-git-send-email-jose.marchesi@oracle.com> <87fva5718n.fsf@redhat.com> <87vbj15mef.fsf@redhat.com> In-Reply-To: <87vbj15mef.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00432.txt.bz2 On 02/17/2015 01:58 AM, Sergio Durigan Junior wrote: > On Monday, February 16 2015, I wrote: > >> On Monday, February 02 2015, Jose E. Marchesi wrote: >> >>> This patch adds some simple tests testing the support for DTrace USDT >>> probes. The testsuite will be skipped as unsupported in case the user >>> does not have DTrace installed on her system. The tests included in the >>> test suite test breakpointing on DTrace probes, enabling and disabling >>> probes, printing of probe arguments of several types and also >>> breakpointing on several probes with the same name. >> >> Thanks again for this awesome testcase. I don't have any more comments >> to make about the patch itself; I personally liked your way of solving >> the transform problem, though I have a preference to see those changes >> in a different patch (i.e., not in the DTrace series). Do you think you >> can do that? It should be really easy to extract this part from your >> patch; and then, you'd only have to worry about the dtrace-side of it. >> If we don't do that, we'd need to duplicate the transform logic in testsuite/configure.ac. It's fine with me to add transform.m4 now, avoiding the duplication. >> I can't give you an approval for the transform.m4 thing, but for the >> rest, you have an OK. > > I forgot to add Pedro in the loop. Pedro, do you have any comments > about this? It looks good to me as is. Thanks, Pedro Alves