From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24079 invoked by alias); 17 Feb 2015 01:57:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23486 invoked by uid 89); 17 Feb 2015 01:57:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Feb 2015 01:57:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1H1vii2019442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Feb 2015 20:57:44 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1H1viZa017184 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 16 Feb 2015 20:57:44 -0500 From: Sergio Durigan Junior To: "Jose E. Marchesi" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH V4 0/9] Add support for DTrace USDT probes to gdb References: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> X-URL: http://blog.sergiodj.net Date: Tue, 17 Feb 2015 01:57:00 -0000 In-Reply-To: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> (Jose E. Marchesi's message of "Mon, 2 Feb 2015 12:02:39 +0100") Message-ID: <877fvh710o.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00381.txt.bz2 On Monday, February 02 2015, Jose E. Marchesi wrote: > [Changes from V3: > - Added some missing spaces after periods in the documentation patch. > Spotted by Eli. > - Sort ChangeLog entries so they reflect the changes in the same order > than the diffs. > - Use transformed tool names in the pdtrace script, which is now > processed through configure. Introduce a new GDB_AC_TRANSFORM macro > to avoid repeating a code idiom and use it to define both > GDB_TRANSFORM_NAME and GCORE_TRANSFORM_NAME in the main > configure.ac. > - Copyright year updated to 2015 in new files introduces by the patch > series.] Thanks for the series, Jose! The patches look pretty good. I approved almost all of them. The only exception is the testcase patch, but not because of the testcase per se: rather, it is because the new transform.m4 file that you added. I think we're 99% done on this. Let's just wait to see what Pedro thinks about the transform thing (since he was the one who requested it before). I'm looking forward to seeing this series pushed. Nice work! Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/