Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdbserver: make target_pid_to_str return std::string
Date: Mon, 25 Oct 2021 12:29:19 -0600	[thread overview]
Message-ID: <877de1q7pc.fsf@tromey.com> (raw)
In-Reply-To: <20211025142033.420979-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 25 Oct 2021 10:20:33 -0400")

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> This doesn't work, because target_pid_to_str stores its result in a
Simon> static buffer, so my message would show twice the same ptid.  Change
Simon> target_pid_to_str to return an std::string to avoid this.  I don't think
Simon> we save much by using a static buffer, but it is more error-prone.

I agree and I think this is fine.

thanks,
Tom

  reply	other threads:[~2021-10-25 18:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 14:20 Simon Marchi via Gdb-patches
2021-10-25 18:29 ` Tom Tromey [this message]
2021-10-25 18:33   ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877de1q7pc.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox