From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OVWuDY33dmGTfQAAWB0awg (envelope-from ) for ; Mon, 25 Oct 2021 14:29:33 -0400 Received: by simark.ca (Postfix, from userid 112) id 2E8661F0BD; Mon, 25 Oct 2021 14:29:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 960F51ECEB for ; Mon, 25 Oct 2021 14:29:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2BA50385743C for ; Mon, 25 Oct 2021 18:29:32 +0000 (GMT) Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.147]) by sourceware.org (Postfix) with ESMTPS id 0EAFF3858412 for ; Mon, 25 Oct 2021 18:29:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0EAFF3858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id A11C4400C83D5 for ; Mon, 25 Oct 2021 13:29:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id f4immX0p1OnCIf4immC6FM; Mon, 25 Oct 2021 13:29:20 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aBMlw0qy9oDL/VpkOIU8aC98WvZA9WhxOigEz2arK9k=; b=TMxoPEUt3aBDYYsMCUNVsTA21P iBvBPFFaa+wwkK2qg/uj1Qt0N5dnkP0OKjywBeDXYcxuZ4I691G5MDJSZYT9F6VB9sVT64lPShyTW XcUhbbZFk+wqdxYOWp3a6OO0b; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:54064 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mf4im-004Dzp-7w; Mon, 25 Oct 2021 12:29:20 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdbserver: make target_pid_to_str return std::string References: <20211025142033.420979-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 25 Oct 2021 12:29:19 -0600 In-Reply-To: <20211025142033.420979-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 25 Oct 2021 10:20:33 -0400") Message-ID: <877de1q7pc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mf4im-004Dzp-7w X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:54064 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> This doesn't work, because target_pid_to_str stores its result in a Simon> static buffer, so my message would show twice the same ptid. Change Simon> target_pid_to_str to return an std::string to avoid this. I don't think Simon> we save much by using a static buffer, but it is more error-prone. I agree and I think this is fine. thanks, Tom