From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdbserver: make target_pid_to_str return std::string
Date: Mon, 25 Oct 2021 14:33:40 -0400 [thread overview]
Message-ID: <190e0714-617a-7a96-b586-7a22a3db987c@polymtl.ca> (raw)
In-Reply-To: <877de1q7pc.fsf@tromey.com>
On 2021-10-25 14:29, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> This doesn't work, because target_pid_to_str stores its result in a
> Simon> static buffer, so my message would show twice the same ptid. Change
> Simon> target_pid_to_str to return an std::string to avoid this. I don't think
> Simon> we save much by using a static buffer, but it is more error-prone.
>
> I agree and I think this is fine.
>
> thanks,
> Tom
>
Thanks, pushed.
Simon
prev parent reply other threads:[~2021-10-25 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 14:20 Simon Marchi via Gdb-patches
2021-10-25 18:29 ` Tom Tromey
2021-10-25 18:33 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190e0714-617a-7a96-b586-7a22a3db987c@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox