Re: [PATCH] gdb/dwarf2: don't sign-extend DW_FORM_data<n> enumerator constants

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:

Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
Simon> Commit 5363deffcfb1 ("Use correct sign extension for enumeration types")
Simon> made update_enumeration_type_from_children read enumerator constants
Simon> with attribute::signed_constant when the enumeration type is not
Simon> explicitly known to be unsigned (through the underlying type).  That
Simon> sign-extends values of forms such as DW_FORM_data1, which is wrong for
Simon> the constants that GCC actually emits.

Ok.
Approved-By: Tom Tromey <tom@tromey.com>

Simon> This is a regression that appeared in GDB 17, meaning there is already
Simon> one broken release out there.  Should we consider this patch for the GDB
Simon> 18 branch?

Seems reasonable to me.

Tom