From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CQoRFCMXpGqOUgAAWB0awg (envelope-from ) for ; Fri, 11 Sep 2026 10:58:43 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NAxYKAJI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4A81E1E09E; Fri, 11 Sep 2026 10:58:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CCB0F1E091 for ; Fri, 11 Sep 2026 10:58:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 675054901400 for ; Fri, 11 Sep 2026 14:58:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 675054901400 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NAxYKAJI Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id EC58B4BA2E3D for ; Fri, 11 Sep 2026 14:58:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC58B4BA2E3D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EC58B4BA2E3D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789138697; cv=none; b=jU/OvYE9x3OBsGFjRCqbvk6X4zWrGf8Soqp/2Co5IwmgurHLqTD+unAWvqbBAUO7nnAnxyUfsUDOc/E7ZPNbJGEhedkiyM21PQ++rFbhYLumKKRe9bTpun9qCePrJ0JCPee+BpTnh2FtVcXY8FUtBvE7lb4seJOQQK8APoBmnp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789138697; c=relaxed/simple; bh=ybnToIqV3rmKt6uGC+V/W2RiLVe4/9dRzAnaxDECuCI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MZZA82VoAuKzjgVeclX89fr1chYXhtt+lESPJO+bZz5+i57qEytHEDNiJhvJwNoKR+W3qPu0UoK3IC+zJnBjYkl8lOj9/iRpudw6mpNtz2jfpSsvHriTb+GBRAn1IqslOk1tRC07wnRhViGAos+1qxeAfeCMVNBa+p22DS5F7tQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NAxYKAJI reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC58B4BA2E3D Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id 50rLx6QbtuFzg52hkxHWhO; Fri, 11 Sep 2026 14:58:16 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 52hjxrBYYF2DA52hjxxDA9; Fri, 11 Sep 2026 14:58:16 +0000 X-Authority-Analysis: v=2.4 cv=FaM3xI+6 c=1 sm=1 tr=0 ts=6aa41708 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=3kAXL7LJXFGLp0o0_lIA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jqavlbIbZeTuYgup7BhQ4II/ewyGSbieNOKO/hzsqyo=; b=NAxYKAJIGPzMLWXHgcfcj+AkJ3 a3uQdhz/AeSLuYNgWqKAV7AclaXR6MsTa85xl+xlxY1STg3h7FxUkivWvccOhgXjqcBDKC/YUWlp+ 56UL1G/2YEFLZ+STHwgAiwvRs; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:42276 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x52hj-00000002FQf-10d3; Fri, 11 Sep 2026 08:58:15 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf2: don't sign-extend DW_FORM_data enumerator constants In-Reply-To: <20260910022902.895931-1-simon.marchi@polymtl.ca> (simon marchi's message of "Wed, 9 Sep 2026 22:25:56 -0400") References: <20260910022902.895931-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 11 Sep 2026 08:58:13 -0600 Message-ID: <877bkrzvga.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x52hj-00000002FQf-10d3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:42276 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJtsOqqkdKjEFRHTcAjjov5dBqJkMvRsbYjG6SpLZ6tUYmmRCopeFREU7gAmjcZAWfxkxDKqrAswl5qOJ8BCmQf7/UY6ApwHUSnple5TMNHrRpMGLyVX 5rHG8p0jI2r2sPTV8BZN4wIQDzI+Ai7y0fApTK0zxMne+P/VjTLot98l1iG7v0uw1pR/sxrTqrXsis5uTU4kjRzhA1Cmnbp64AM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> Commit 5363deffcfb1 ("Use correct sign extension for enumeration types") Simon> made update_enumeration_type_from_children read enumerator constants Simon> with attribute::signed_constant when the enumeration type is not Simon> explicitly known to be unsigned (through the underlying type). That Simon> sign-extends values of forms such as DW_FORM_data1, which is wrong for Simon> the constants that GCC actually emits. Ok. Approved-By: Tom Tromey Simon> This is a regression that appeared in GDB 17, meaning there is already Simon> one broken release out there. Should we consider this patch for the GDB Simon> 18 branch? Seems reasonable to me. Tom