From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf2: don't sign-extend DW_FORM_data<n> enumerator constants
Date: Fri, 11 Sep 2026 21:46:49 -0400 [thread overview]
Message-ID: <571eddaf-61f3-434b-abc3-89726549a2b3@polymtl.ca> (raw)
In-Reply-To: <877bkrzvga.fsf@tromey.com>
On 2026-09-11 10:58, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
> Simon> Commit 5363deffcfb1 ("Use correct sign extension for enumeration types")
> Simon> made update_enumeration_type_from_children read enumerator constants
> Simon> with attribute::signed_constant when the enumeration type is not
> Simon> explicitly known to be unsigned (through the underlying type). That
> Simon> sign-extends values of forms such as DW_FORM_data1, which is wrong for
> Simon> the constants that GCC actually emits.
>
> Ok.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Simon> This is a regression that appeared in GDB 17, meaning there is already
> Simon> one broken release out there. Should we consider this patch for the GDB
> Simon> 18 branch?
>
> Seems reasonable to me.
>
> Tom
Thanks, pushed to master and gdb-18-branch.
Simon
prev parent reply other threads:[~2026-09-12 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 2:25 simon.marchi
2026-09-11 14:58 ` Tom Tromey
2026-09-12 1:46 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571eddaf-61f3-434b-abc3-89726549a2b3@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox