From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 68XxIyivpGoIMQIAWB0awg (envelope-from ) for ; Fri, 11 Sep 2026 21:47:20 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=P38i/goq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 841651E033; Fri, 11 Sep 2026 21:47:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BA3861E033 for ; Fri, 11 Sep 2026 21:47:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E1294C3182D for ; Sat, 12 Sep 2026 01:47:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E1294C3182D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=P38i/goq Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B09424B9208C for ; Sat, 12 Sep 2026 01:46:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B09424B9208C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B09424B9208C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789177616; cv=none; b=B+YWQNGySNTiyY0NsmXTAfsP9RQ54/rjHt3YYMmZeYEjw/9HB3cvfRzhJ7W3+9mWFf/E6o2wUia4ltsaneu/sGVhghb7wL/reHc4sr6zMzxRSM/L9diOWXSj6pRI3jDY7MFRc6LftWtgGz+5v9ldfREE8pC/QB0k7WAuKALMQDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789177616; c=relaxed/simple; bh=jQ5bnFSpDUooPE5mRgw/XdSaLuqpKWAPkRTmSzsDEmw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jzBhPcr7oOf9zpPsNOIZ08bXICAyeZNV24Xatpor5Xtrrb3be44KjpoqLxarzccV/wc55lGSGC7qON1Up5R94Dl5/UHVK76n1PLqjws+4k+o3xL7xh5978rKzry7juqKUyvo6XaG2+/Hcp+vKUO4/epNsh7NpOn8wHYGRGSAdFM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=P38i/goq DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B09424B9208C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 68C1komh146211 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Sep 2026 21:46:55 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 68C1komh146211 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1789177616; bh=AlDB9HGlVEU5X4qg+59Cex38o99pafOmyeU3n9clKRs=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=P38i/goquwKxqP9tvWyIoLM1CVGGTiNUySSQZhTIySu0CQDnXj3u37dOtygITbOX7 fzusNlAOPUSZG1rGLK7Fd8Mw6D2BDXNZ/nMvEi+0mLEeMgx3hnkdcylnRdiononMwE VyHawWcL3VO3KxAWVmT5biuM22Boq8WQH4E8zvPutz59Uf3uAB2FDONL8bPdTuGPlF WeVFcXk7LtVHXSWkR9/Fz560y+8VcdiF72OtIoXb3/wHod5o4WIoQsTKupKcuT1+OW lG6Rs3d/JIw+FoRgrDZ2ez8EOVDvpU7KGeqj7Py0He2+mQ3tCLDphASPduJzrEJQlW 4wkCM5IlTRSug== Received: by simark.ca (Postfix) id 49DCC1E033; Fri, 11 Sep 2026 21:46:50 -0400 (EDT) Message-ID: <571eddaf-61f3-434b-abc3-89726549a2b3@polymtl.ca> Date: Fri, 11 Sep 2026 21:46:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf2: don't sign-extend DW_FORM_data enumerator constants To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260910022902.895931-1-simon.marchi@polymtl.ca> <877bkrzvga.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <877bkrzvga.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 12 Sep 2026 01:46:50 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-11 10:58, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> Commit 5363deffcfb1 ("Use correct sign extension for enumeration types") > Simon> made update_enumeration_type_from_children read enumerator constants > Simon> with attribute::signed_constant when the enumeration type is not > Simon> explicitly known to be unsigned (through the underlying type). That > Simon> sign-extends values of forms such as DW_FORM_data1, which is wrong for > Simon> the constants that GCC actually emits. > > Ok. > Approved-By: Tom Tromey > > Simon> This is a regression that appeared in GDB 17, meaning there is already > Simon> one broken release out there. Should we consider this patch for the GDB > Simon> 18 branch? > > Seems reasonable to me. > > Tom Thanks, pushed to master and gdb-18-branch. Simon