Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: ezannoni@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: Patch ping
Date: Fri, 07 Dec 2001 11:02:00 -0000	[thread overview]
Message-ID: <87667irguy.fsf@creche.redhat.com> (raw)
In-Reply-To: "Eli Zaretskii"'s message of "Fri, 07 Dec 2001 20:45:36 +0200"

>>>>> "Eli" == Eli Zaretskii <eliz@is.elta.co.il> writes:

Eli> Hmm... I probably am missing something obvious, but fragments
Eli> like this one:

Eli>     +  if (IS_ABSOLUTE_PATH (name))
Eli>     +    real_path = gdb_realpath (name);
Eli>     +

Eli> confuse me.  Aren't they supposed to convert non-absolute file
Eli> name, that is, say "if (!IS_ABSOLUTE_PATH (name))"?

No, these calls canonicalize absolute paths.  I believe realpath()
isn't guaranteed to do anything sensible with a relative path.  I will
add comments to this effect.

Tom


  reply	other threads:[~2001-12-07 19:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-07  7:50 Tom Tromey
2001-12-07  8:14 ` Elena Zannoni
2001-12-07 10:00   ` Keith Seitz
2001-12-08 19:57   ` Tom Tromey
2001-12-07 10:46 ` Eli Zaretskii
2001-12-07 11:02   ` Tom Tromey [this message]
2002-01-24 17:25 Tom Tromey
2002-05-13 11:06 Don Howard
2002-05-16 15:54 ` Jim Blandy
2004-04-30 16:27 Ulrich Weigand
2004-04-30 17:33 ` Andrew Cagney
2004-04-30 18:13   ` Ulrich Weigand
2004-04-30 22:19     ` Jim Blandy
2004-04-30 22:51       ` Ulrich Weigand
2004-05-02 20:49     ` Andrew Cagney
2004-05-01 19:48       ` Ulrich Weigand
2004-04-30 22:26 ` Jim Blandy
2004-05-01 15:41   ` Ulrich Weigand
2004-05-02 20:49     ` Jim Blandy
2004-05-27 13:07 Paul Brook
2004-05-27 21:20 ` Jason Molenda
2004-05-28 23:37 ` Jim Blandy
2008-07-10 19:34 Tom Tromey
2016-09-14 19:27 patch ping Tom Tromey
2016-09-27 17:38 ` Tom Tromey
2016-09-27 17:50   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87667irguy.fsf@creche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@is.elta.co.il \
    --cc=ezannoni@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox