From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19119 invoked by alias); 7 Dec 2001 19:02:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18409 invoked from network); 7 Dec 2001 19:00:45 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 7 Dec 2001 19:00:45 -0000 Received: from creche.cygnus.com (ta0205.peakpeak.com [204.144.244.205]) by gash2.peakpeak.com (8.9.3/8.9.3) with ESMTP id MAA17533; Fri, 7 Dec 2001 12:00:34 -0700 Received: (from tromey@localhost) by creche.cygnus.com (8.9.3/8.9.3) id MAA25587; Fri, 7 Dec 2001 12:05:09 -0700 To: Eli Zaretskii Cc: ezannoni@cygnus.com, gdb-patches@sources.redhat.com Subject: Re: Patch ping References: <87snan6n7u.fsf@creche.redhat.com> <2593-Fri07Dec2001204536+0200-eliz@is.elta.co.il> X-Zippy: I was making donuts and now I'm on a bus! X-Attribution: Tom Reply-To: tromey@redhat.com From: Tom Tromey Date: Fri, 07 Dec 2001 11:02:00 -0000 In-Reply-To: "Eli Zaretskii"'s message of "Fri, 07 Dec 2001 20:45:36 +0200" Message-ID: <87667irguy.fsf@creche.redhat.com> X-Mailer: Gnus v5.7/Emacs 20.5 X-SW-Source: 2001-12/txt/msg00205.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> Hmm... I probably am missing something obvious, but fragments Eli> like this one: Eli> + if (IS_ABSOLUTE_PATH (name)) Eli> + real_path = gdb_realpath (name); Eli> + Eli> confuse me. Aren't they supposed to convert non-absolute file Eli> name, that is, say "if (!IS_ABSOLUTE_PATH (name))"? No, these calls canonicalize absolute paths. I believe realpath() isn't guaranteed to do anything sensible with a relative path. I will add comments to this effect. Tom