From: Tom Tromey <tromey@redhat.com>
To: lgustavo@codesourcery.com
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix mi "-var-create" regression
Date: Tue, 30 Oct 2012 20:36:00 -0000 [thread overview]
Message-ID: <87625rwvcp.fsf@fleche.redhat.com> (raw)
In-Reply-To: <508DB53E.30507@codesourcery.com> (Luis Machado's message of "Sun, 28 Oct 2012 20:44:14 -0200")
>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
Luis> 2012-10-15 Luis Machado <lgustavo@codesourcery.com>
Luis> * value.c (value_actual_type): Check for TYPE_CODE_STRUCT
Luis> target types.
Luis> testsuite/
Luis> * mi-var-create-rtti.c: New file.
Luis> * mi-var-create-rtti.exp: New file.
This looks good to me. One tiny nit:
Luis> Index: gdb/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp
Luis> + return -1;
No need for a ";" here.
Ok with this change.
thanks,
Tom
next prev parent reply other threads:[~2012-10-30 20:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 20:05 Luis Gustavo
2012-10-11 21:53 ` Sergio Durigan Junior
2012-10-11 22:10 ` Luis Machado
2012-10-17 17:29 ` Tom Tromey
2012-10-12 19:57 ` Marc Khouzam
2012-10-14 17:18 ` Joel Brobecker
2012-10-15 12:21 ` Luis Machado
2012-10-18 1:13 ` Tom Tromey
2012-10-19 13:14 ` Luis Machado
2012-10-28 22:44 ` Luis Machado
2012-10-30 20:36 ` Tom Tromey [this message]
2012-11-14 19:21 ` Luis Machado
2012-11-15 16:44 ` Marc Khouzam
2012-11-15 17:48 ` Joel Brobecker
2012-11-15 18:47 ` Tom Tromey
2012-11-15 20:54 ` Marc Khouzam
2012-11-15 21:13 ` Tom Tromey
2012-11-15 23:28 ` Luis Machado
2012-11-16 0:50 ` Marc Khouzam
2012-11-16 2:10 ` Luis Machado
2012-11-29 20:11 ` Andreas Schwab
2012-11-29 21:07 ` Joel Brobecker
2012-11-30 2:13 ` Luis Machado
2012-12-07 2:48 ` Joel Brobecker
2012-12-07 2:51 ` Luis Machado
2012-12-26 12:31 ` Luis Machado
2013-01-03 3:46 ` Joel Brobecker
2013-01-03 12:30 ` Luis Machado
2013-01-03 12:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87625rwvcp.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox