From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7802 invoked by alias); 30 Oct 2012 20:36:59 -0000 Received: (qmail 7706 invoked by uid 22791); 30 Oct 2012 20:36:56 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Oct 2012 20:36:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9UKaPO7001432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Oct 2012 16:36:25 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9UKaMSF003213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 30 Oct 2012 16:36:23 -0400 From: Tom Tromey To: lgustavo@codesourcery.com Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix mi "-var-create" regression References: <5075D4FD.9050900@mentor.com> <20121014171805.GB3050@adacore.com> <507BFF97.2000900@codesourcery.com> <87y5j4ziof.fsf@fleche.redhat.com> <508DB53E.30507@codesourcery.com> Date: Tue, 30 Oct 2012 20:36:00 -0000 In-Reply-To: <508DB53E.30507@codesourcery.com> (Luis Machado's message of "Sun, 28 Oct 2012 20:44:14 -0200") Message-ID: <87625rwvcp.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00556.txt.bz2 >>>>> "Luis" == Luis Machado writes: Luis> 2012-10-15 Luis Machado Luis> * value.c (value_actual_type): Check for TYPE_CODE_STRUCT Luis> target types. Luis> testsuite/ Luis> * mi-var-create-rtti.c: New file. Luis> * mi-var-create-rtti.exp: New file. This looks good to me. One tiny nit: Luis> Index: gdb/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp Luis> + return -1; No need for a ";" here. Ok with this change. thanks, Tom