Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix mi "-var-create" regression
Date: Fri, 19 Oct 2012 13:14:00 -0000	[thread overview]
Message-ID: <50815220.7050209@codesourcery.com> (raw)
In-Reply-To: <87y5j4ziof.fsf@fleche.redhat.com>

Hi Tom,

On 10/17/2012 10:13 PM, Tom Tromey wrote:
>>>>>> "Luis" == Luis Machado<lgustavo@codesourcery.com>  writes:
>
> Luis>  +	&&  TYPE_CODE (TYPE_TARGET_TYPE (result)) != TYPE_CODE_VOID)
>
> On further reflection, I have a question and a comment.
>
> First, perhaps instead of excluding void* here, we should only allow
> pointers to structs.  That is the only case that has RTTI anyhow.  What
> do you think?

That sounds reasonable to me.
>
> Also, I think this needs a check_typedef around TYPE_TARGET_TYPE.
>

Probably. If the target type is deep into a typedef pile, we won't get 
this right.

I'll have it fixed and will provide that testcase.

Thanks!
Luis


  reply	other threads:[~2012-10-19 13:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10 20:05 Luis Gustavo
2012-10-11 21:53 ` Sergio Durigan Junior
2012-10-11 22:10   ` Luis Machado
2012-10-17 17:29     ` Tom Tromey
2012-10-12 19:57 ` Marc Khouzam
2012-10-14 17:18 ` Joel Brobecker
2012-10-15 12:21   ` Luis Machado
2012-10-18  1:13     ` Tom Tromey
2012-10-19 13:14       ` Luis Machado [this message]
2012-10-28 22:44       ` Luis Machado
2012-10-30 20:36         ` Tom Tromey
2012-11-14 19:21           ` Luis Machado
2012-11-15 16:44             ` Marc Khouzam
2012-11-15 17:48               ` Joel Brobecker
2012-11-15 18:47                 ` Tom Tromey
2012-11-15 20:54                   ` Marc Khouzam
2012-11-15 21:13                     ` Tom Tromey
2012-11-15 23:28                     ` Luis Machado
2012-11-16  0:50                       ` Marc Khouzam
2012-11-16  2:10                         ` Luis Machado
2012-11-29 20:11         ` Andreas Schwab
2012-11-29 21:07           ` Joel Brobecker
2012-11-30  2:13             ` Luis Machado
2012-12-07  2:48               ` Joel Brobecker
2012-12-07  2:51                 ` Luis Machado
2012-12-26 12:31                   ` Luis Machado
2013-01-03  3:46                     ` Joel Brobecker
2013-01-03 12:30                       ` Luis Machado
2013-01-03 12:38                         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50815220.7050209@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox