Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Pedro Alves <palves@redhat.com>,
	gdb-patches@sourceware.org,        pmuldoon@redhat.com,
	eliz@gnu.org
Subject: Re: [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint
Date: Fri, 15 Nov 2013 20:58:00 -0000	[thread overview]
Message-ID: <8761rttr15.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAP9bCMRMZGrBgpToFp4RzA0f9TthKy8Kg9hqL_ENX=6B0yUdzg@mail.gmail.com>	(Doug Evans's message of "Thu, 14 Nov 2013 21:34:31 -0800")

>>>>> "Doug" == Doug Evans <xdje42@gmail.com> writes:

Doug> Need More Data.

That goes both ways.

If you still prefer the other semantics, perhaps you could explain why.

Doug> In this scenario, when would one typically add a CLI condition to such
Doug> a Python interpreter breakpoint?

It's a flaw in this example.  But the example is just an example.  I
would hope it does not need to be bulletproof in order to persuade one
that perhaps the proposed semantics are not obviously ideal.

Doug> Plus if this is really a check_status thing then I wonder if
Doug> gdb.Breakpoint is going down the wrong path and we should be providing
Doug> a class where users can override breakpoint_ops.

Yes.  However that ran aground of difficulties when attempted.  The main
issue, I think -- and this goes back to the ABI business -- is that
breakpoint_ops are a bit weird; and breakpoint.c is clearly in need of
some refactoring and more replacement of bptype checks with method
calls.

I'd be delighted if somebody did this.  It hasn't made the top of our
list yet.

Tom


  parent reply	other threads:[~2013-11-15 19:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13  8:11 [commit] breakpoint.c (breakpoint_cond_eval): Fix and enhance comment Doug Evans
2013-11-14 17:58 ` [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint Doug Evans
2013-11-14 18:44   ` Pedro Alves
2013-11-14 20:22   ` Phil Muldoon
2013-11-14 20:54   ` Tom Tromey
2013-11-14 21:21     ` Pedro Alves
2013-11-15  6:39       ` Doug Evans
2013-11-15 12:06         ` Pedro Alves
2013-11-15 16:30           ` Doug Evans
2013-11-15 16:45             ` Pedro Alves
2013-11-17 17:22               ` Doug Evans
2013-11-15 20:58         ` Tom Tromey [this message]
2013-11-17 17:59           ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761rttr15.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=pmuldoon@redhat.com \
    --cc=xdje42@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox