From: Pedro Alves <palves@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com, eliz@gnu.org
Subject: Re: [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint
Date: Thu, 14 Nov 2013 18:44:00 -0000 [thread overview]
Message-ID: <528516E0.5090708@redhat.com> (raw)
In-Reply-To: <m3k3gaq3gw.fsf@seba.sebabeach.org>
On 11/14/2013 05:48 PM, Doug Evans wrote:
> Regression tested on amd64-linux.
>
> Ok to check in?
>
This is fine with me.
> - if (cond && b->disposition != disp_del_at_next_stop)
> + if (cli_cond && b->disposition != disp_del_at_next_stop)
(BTW, I notice that the 'b->disposition != disp_del_at_next_stop'
handling in this function looks suspicious.)
> if (within_current_scope)
> - value_is_zero
> - = catch_errors (breakpoint_cond_eval, cond,
> + {
> + int cond_result =
= goes on the next line.
--
Pedro Alves
next prev parent reply other threads:[~2013-11-14 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 8:11 [commit] breakpoint.c (breakpoint_cond_eval): Fix and enhance comment Doug Evans
2013-11-14 17:58 ` [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint Doug Evans
2013-11-14 18:44 ` Pedro Alves [this message]
2013-11-14 20:22 ` Phil Muldoon
2013-11-14 20:54 ` Tom Tromey
2013-11-14 21:21 ` Pedro Alves
2013-11-15 6:39 ` Doug Evans
2013-11-15 12:06 ` Pedro Alves
2013-11-15 16:30 ` Doug Evans
2013-11-15 16:45 ` Pedro Alves
2013-11-17 17:22 ` Doug Evans
2013-11-15 20:58 ` Tom Tromey
2013-11-17 17:59 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528516E0.5090708@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox