From: Phil Muldoon <pmuldoon@redhat.com>
To: Doug Evans <xdje42@gmail.com>,
gdb-patches@sourceware.org, palves@redhat.com,
eliz@gnu.org
Subject: Re: [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint
Date: Thu, 14 Nov 2013 20:22:00 -0000 [thread overview]
Message-ID: <52852E97.6010809@redhat.com> (raw)
In-Reply-To: <m3k3gaq3gw.fsf@seba.sebabeach.org>
On 14/11/13 17:48, Doug Evans wrote:
> Hi.
>
> Way back when this was added I wanted to prevent both CLI and Python
> conditions from being set on the same breakpoint because it wasn't
> clear there wouldn't be any problems allowing both.
> [And it's easier to relax restrictions than to impose them after the fact.]
No objections from me. I have not looked at the patch in the context
of breakpoint.c, but as long as all "stop" callbacks have a chance to
run regardless of whether a previous "stop" or cli condition has had a
chance to execute it is fine. Looking at the patch, it seems it did
not alter this loop, so this is still the case, is that right?
Cheers,
Phil
next prev parent reply other threads:[~2013-11-14 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 8:11 [commit] breakpoint.c (breakpoint_cond_eval): Fix and enhance comment Doug Evans
2013-11-14 17:58 ` [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint Doug Evans
2013-11-14 18:44 ` Pedro Alves
2013-11-14 20:22 ` Phil Muldoon [this message]
2013-11-14 20:54 ` Tom Tromey
2013-11-14 21:21 ` Pedro Alves
2013-11-15 6:39 ` Doug Evans
2013-11-15 12:06 ` Pedro Alves
2013-11-15 16:30 ` Doug Evans
2013-11-15 16:45 ` Pedro Alves
2013-11-17 17:22 ` Doug Evans
2013-11-15 20:58 ` Tom Tromey
2013-11-17 17:59 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52852E97.6010809@redhat.com \
--to=pmuldoon@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox