Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb, c++] Improve error message when using libstdcxx without SDT probes
Date: Fri, 26 Jul 2019 21:00:00 -0000	[thread overview]
Message-ID: <875znoqzot.fsf@tromey.com> (raw)
In-Reply-To: <20190725210447.GA26123@delia> (Tom de Vries's message of "Thu,	25 Jul 2019 23:04:49 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> When using catch catch/rethrow/catch, a libstdcxx with SDT probes is required
Tom> for both the regexp argument, and the convenience variable $_exception (
Tom> https://sourceware.org/gdb/current/onlinedocs/gdb/Set-Catchpoints.html ).

Tom> +  if (pc_probe.prob == NULL)
Tom> +    error (_("did not find exception probe (does libstdcxx have SDT probes?)"));

I think it's more normal to start an error with a capital letter.
Also I'd suggest writing "libstdc++" here.

Ok with those changes.

thanks,
Tom


  reply	other threads:[~2019-07-26 21:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 21:04 Tom de Vries
2019-07-26 21:00 ` Tom Tromey [this message]
2019-08-13 13:51 ` [PING][PATCH][gdb, " Tom de Vries
2019-08-26  8:47   ` [PING^2][PATCH][gdb, " Tom de Vries
2019-08-26 14:11 ` [PATCH][gdb, " Sergio Durigan Junior
2019-08-26 16:51   ` [committed][gdb/testsuite] Make skip_libstdcxx_probe_tests return 1 if true Tom de Vries
2019-08-26 17:02     ` Sergio Durigan Junior
2019-08-26 17:27   ` [PATCH][gdb, c++] Improve error message when using libstdcxx without SDT probes Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875znoqzot.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox