From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111924 invoked by alias); 26 Jul 2019 21:00:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111832 invoked by uid 89); 26 Jul 2019 21:00:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=letter X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jul 2019 21:00:13 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id E3EF9FD07 for ; Fri, 26 Jul 2019 16:00:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id r7JrhLcXh90onr7JshDk5E; Fri, 26 Jul 2019 16:00:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sYTcWTRiewMmNQ5rhsqzgDYKce5X7CKfjsTkqmJfG8o=; b=V8Ve2wiNnAl2Fm1Vnutqu++8YA aoYqfkMrj6jUXlYvKNmOVNDuX/wXLNUnHNW+LQvGRJ5wh0rMabHxUCFmqZ7om/iwovK43gq9YR5aI +GRUWMOgLqVbvYtuRUXpzL84I; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:55084 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hr7Jr-0037jO-O8; Fri, 26 Jul 2019 16:00:03 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb, c++] Improve error message when using libstdcxx without SDT probes References: <20190725210447.GA26123@delia> Date: Fri, 26 Jul 2019 21:00:00 -0000 In-Reply-To: <20190725210447.GA26123@delia> (Tom de Vries's message of "Thu, 25 Jul 2019 23:04:49 +0200") Message-ID: <875znoqzot.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00595.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> When using catch catch/rethrow/catch, a libstdcxx with SDT probes is required Tom> for both the regexp argument, and the convenience variable $_exception ( Tom> https://sourceware.org/gdb/current/onlinedocs/gdb/Set-Catchpoints.html ). Tom> + if (pc_probe.prob == NULL) Tom> + error (_("did not find exception probe (does libstdcxx have SDT probes?)")); I think it's more normal to start an error with a capital letter. Also I'd suggest writing "libstdc++" here. Ok with those changes. thanks, Tom