From: Tom Tromey <tom@tromey.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/7] Use C++17 [[fallthrough]] attribute
Date: Thu, 19 Oct 2023 14:23:31 -0600 [thread overview]
Message-ID: <875y32wed8.fsf@tromey.com> (raw)
In-Reply-To: <2f6cedab-d96e-8646-01e6-ceb63b772b35@FreeBSD.org> (John Baldwin's message of "Mon, 16 Oct 2023 16:17:23 -0700")
>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
John> On 10/16/23 4:02 PM, Tom Tromey wrote:
>> This changes gdb to use the C++17 [[fallthrough]] attribute rather
>> than special comments.
>> This was mostly done by script, but I neglected a few spellings and
>> so
>> also fixed it up by hand.
>> I suspect this fixes the bug mentioned below, by switching to a
>> standard approach that, presumably, clang supports.
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=23159
John> The fbsd-nat.c change is explicitly ok with me.
I added your approved-by.
Tom
next prev parent reply other threads:[~2023-10-19 20:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 23:02 [PATCH 0/7] More C++17 Updates Tom Tromey
2023-10-16 23:02 ` [PATCH 1/7] Use C++17 [[fallthrough]] attribute Tom Tromey
2023-10-16 23:17 ` John Baldwin
2023-10-19 20:23 ` Tom Tromey [this message]
2023-10-17 8:53 ` Luis Machado
2023-10-19 20:23 ` Tom Tromey
2023-10-16 23:02 ` [PATCH 2/7] Switch to -Wimplicit-fallthrough=5 Tom Tromey
2023-10-16 23:02 ` [PATCH 3/7] Enable some C++14 code in array-view.h Tom Tromey
2023-10-16 23:02 ` [PATCH 4/7] Use try_emplace in index-write.c Tom Tromey
2023-10-17 8:56 ` Pedro Alves
2023-10-17 9:30 ` Lancelot SIX
2023-10-19 20:24 ` Tom Tromey
2023-10-16 23:02 ` [PATCH 5/7] Rely on C++17 <new> in new-op.cc Tom Tromey
2023-10-16 23:02 ` [PATCH 6/7] Rely on copy elision in scope-exit.h Tom Tromey
2023-10-16 23:02 ` [PATCH 7/7] Use C++17 void_t Tom Tromey
2023-10-17 9:06 ` [PATCH 0/7] More C++17 Updates Pedro Alves
2023-10-19 20:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y32wed8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox