From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mB25HVaQMWVWWDIAWB0awg (envelope-from ) for ; Thu, 19 Oct 2023 16:23:50 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XNGD51eJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 755521E0C1; Thu, 19 Oct 2023 16:23:50 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B5E11E091 for ; Thu, 19 Oct 2023 16:23:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3A3D3857C66 for ; Thu, 19 Oct 2023 20:23:47 +0000 (GMT) Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 3A47D3858D28 for ; Thu, 19 Oct 2023 20:23:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A47D3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A47D3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697747017; cv=none; b=GtNz/EyQXMBgj4yxLxkeGrmCuBPXudrU54JqdxIy2v8IRqDQk7xulW4GSNJxBZSU0fuA54i7xeDrb0kiC0spx1a/jS0cZG1gT2gUVXG/b68Wcb1lD/4iD5kkgjGh72Ih5VAG4NrrNTjCtefI2HsK1Q8BL7W1Fzq6tUjwd5ejdCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697747017; c=relaxed/simple; bh=MOJFDNlFx6Adv7/AwwrDg1rwED6kwOjHbSA0QyBpjUM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=b0YhlzkXPS6IYgsroErdO8m7+D8sR4OVU7KdQuYnIljssYxxfqo+SSFAVeTsx6Fo8yf6AwnfRW8NKCCZELSnFKqsjlyRf6Zqws6EZCeW+rH07KZ3FOAsRER47SOOIxHL7qZ6ZIidtachabQEt3H0EbmazKZ2J3rPN2IPJ+IwSx8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTPS id tDbsq3lTs8HtetZYJqyqJT; Thu, 19 Oct 2023 20:23:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id tZYIqUHOqzUR0tZYIql16y; Thu, 19 Oct 2023 20:23:31 +0000 X-Authority-Analysis: v=2.4 cv=ebAuwpIH c=1 sm=1 tr=0 ts=65319043 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=6I5d2MoRAAAA:8 a=CCpqsmhAAAAA:8 a=RzC0AiCZp5jEkOyDwDoA:9 a=IjZwj45LgO3ly-622nXo:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MOJFDNlFx6Adv7/AwwrDg1rwED6kwOjHbSA0QyBpjUM=; b=XNGD51eJFhLkhSiK91QQtajPDH 4jW7VjV64OQJNFWVBVvQZMFGkpX+2kVH5JFWBI9St8HdWxsk11ti8jUBUYu+Iekg23tYf0baVOPOZ AqZjrcHiQTV8ACe3ne0f8DIDX; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:58154 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qtZYI-0006Sf-10; Thu, 19 Oct 2023 14:23:30 -0600 From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] Use C++17 [[fallthrough]] attribute References: <20231016230527.1820819-1-tom@tromey.com> <20231016230527.1820819-2-tom@tromey.com> <2f6cedab-d96e-8646-01e6-ceb63b772b35@FreeBSD.org> X-Attribution: Tom Date: Thu, 19 Oct 2023 14:23:31 -0600 In-Reply-To: <2f6cedab-d96e-8646-01e6-ceb63b772b35@FreeBSD.org> (John Baldwin's message of "Mon, 16 Oct 2023 16:17:23 -0700") Message-ID: <875y32wed8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qtZYI-0006Sf-10 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (prentzel) [71.211.130.31]:58154 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNdbdR+dJCRkXG90a5VMW09g27lt+FvMgiR2vRFvljFtvzxBbotU3hVacnXT92OLaz+TH7IxGOLpqG1cXhkBTQfOUqjUHT11L1Jvol94O0sACwfhryyt jlJB+WpLGWfFriKgOP30rNDGOYmL+TiPRn2El+ApWpId+lEvi18mWLljsB02EikoMJj97Vu8R2ODnBxmN08e/viocBXR/qFIE7M= X-Spam-Status: No, score=-3018.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "John" == John Baldwin writes: John> On 10/16/23 4:02 PM, Tom Tromey wrote: >> This changes gdb to use the C++17 [[fallthrough]] attribute rather >> than special comments. >> This was mostly done by script, but I neglected a few spellings and >> so >> also fixed it up by hand. >> I suspect this fixes the bug mentioned below, by switching to a >> standard approach that, presumably, clang supports. >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=23159 John> The fbsd-nat.c change is explicitly ok with me. I added your approved-by. Tom