From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] More C++17 Updates
Date: Tue, 17 Oct 2023 10:06:59 +0100 [thread overview]
Message-ID: <13d8b3d7-f1e5-41ad-b1dc-d1be245158c6@palves.net> (raw)
In-Reply-To: <20231016230527.1820819-1-tom@tromey.com>
On 2023-10-17 00:02, Tom Tromey wrote:
> This series is based on Lancelot's C++17 series. I found some more
> spots in gdb that could easily take advantage of C++17.
>
> I'm sure there are some more spots to be found. For example, I
> suspect try_embed can be used in more places than the one that was
> commented as such.
I guess you mean try_emplace.
>
> I have another branch where I try to replace gdb::array_view with a
> C++20-compatible std::span. However, this one is a bit more invasive,
> so I thought I would leave it for a little later.
I wish that C++ had went the array_view route, but oh well.
> Note that gdb
> doesn't currently build cleanly in C++20 mode (mostly but IIRC not
> entirely due to the use of 'volatile' in the Guile headers).
>
> Regression tested on x86-64 Fedora 38.
>
> Let me know what you think.
Other than the comment on the try_emplace patch, this all LGTM:
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2023-10-17 9:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 23:02 Tom Tromey
2023-10-16 23:02 ` [PATCH 1/7] Use C++17 [[fallthrough]] attribute Tom Tromey
2023-10-16 23:17 ` John Baldwin
2023-10-19 20:23 ` Tom Tromey
2023-10-17 8:53 ` Luis Machado
2023-10-19 20:23 ` Tom Tromey
2023-10-16 23:02 ` [PATCH 2/7] Switch to -Wimplicit-fallthrough=5 Tom Tromey
2023-10-16 23:02 ` [PATCH 3/7] Enable some C++14 code in array-view.h Tom Tromey
2023-10-16 23:02 ` [PATCH 4/7] Use try_emplace in index-write.c Tom Tromey
2023-10-17 8:56 ` Pedro Alves
2023-10-17 9:30 ` Lancelot SIX
2023-10-19 20:24 ` Tom Tromey
2023-10-16 23:02 ` [PATCH 5/7] Rely on C++17 <new> in new-op.cc Tom Tromey
2023-10-16 23:02 ` [PATCH 6/7] Rely on copy elision in scope-exit.h Tom Tromey
2023-10-16 23:02 ` [PATCH 7/7] Use C++17 void_t Tom Tromey
2023-10-17 9:06 ` Pedro Alves [this message]
2023-10-19 20:26 ` [PATCH 0/7] More C++17 Updates Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13d8b3d7-f1e5-41ad-b1dc-d1be245158c6@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox