From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Udma Catalin-Dan-B32721 <B32721@freescale.com>
Subject: Re: gdb 7.6: Fix info mem command for 32 bits host/64 bits target
Date: Wed, 26 Jun 2013 17:11:00 -0000 [thread overview]
Message-ID: <874nckrf0o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <51CB11D6.1020306@redhat.com> (Pedro Alves's message of "Wed, 26 Jun 2013 17:07:50 +0100")
Pedro> static void
Pedro> breakpoint_adjustment_warning (CORE_ADDR from_addr, CORE_ADDR to_addr,
Pedro> int bnum, int have_bnum)
Pedro> {
Pedro> /* The longest string possibly returned by hex_string_custom
Pedro> is 50 chars. These must be at least that big for safety. */
Pedro> char astr1[64];
Pedro> char astr2[64];
Pedro> strcpy (astr1, hex_string_custom ((unsigned long) from_addr, 8));
Pedro> strcpy (astr2, hex_string_custom ((unsigned long) to_addr, 8));
These strcpy calls are also bogus.
hex_string_custom uses the "cell" mechanism, so this code can assume
that these calls don't interfere.
Tom
next prev parent reply other threads:[~2013-06-26 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 15:10 Udma Catalin-Dan-B32721
2013-06-26 16:07 ` Pedro Alves
2013-06-26 16:11 ` Pedro Alves
2013-06-26 16:17 ` Pedro Alves
2013-06-26 17:11 ` Tom Tromey [this message]
2013-06-26 16:20 ` Udma Catalin-Dan-B32721
2013-06-27 8:42 ` Udma Catalin-Dan-B32721
2013-06-27 8:44 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nckrf0o.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=B32721@freescale.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox