From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11653 invoked by alias); 26 Jun 2013 16:52:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11644 invoked by uid 89); 26 Jun 2013 16:52:13 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_CP autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 26 Jun 2013 16:52:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5QGq99Y003871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Jun 2013 12:52:09 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5QGq7DU005111 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 26 Jun 2013 12:52:08 -0400 From: Tom Tromey To: Pedro Alves Cc: "gdb-patches\@sourceware.org" , Udma Catalin-Dan-B32721 Subject: Re: gdb 7.6: Fix info mem command for 32 bits host/64 bits target References: <51CB116D.7060009@redhat.com> <51CB11D6.1020306@redhat.com> Date: Wed, 26 Jun 2013 17:11:00 -0000 In-Reply-To: <51CB11D6.1020306@redhat.com> (Pedro Alves's message of "Wed, 26 Jun 2013 17:07:50 +0100") Message-ID: <874nckrf0o.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00783.txt.bz2 Pedro> static void Pedro> breakpoint_adjustment_warning (CORE_ADDR from_addr, CORE_ADDR to_addr, Pedro> int bnum, int have_bnum) Pedro> { Pedro> /* The longest string possibly returned by hex_string_custom Pedro> is 50 chars. These must be at least that big for safety. */ Pedro> char astr1[64]; Pedro> char astr2[64]; Pedro> strcpy (astr1, hex_string_custom ((unsigned long) from_addr, 8)); Pedro> strcpy (astr2, hex_string_custom ((unsigned long) to_addr, 8)); These strcpy calls are also bogus. hex_string_custom uses the "cell" mechanism, so this code can assume that these calls don't interfere. Tom