Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Udma Catalin-Dan-B32721 <B32721@freescale.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: gdb 7.6: Fix info mem command for 32 bits host/64 bits target
Date: Wed, 26 Jun 2013 15:10:00 -0000	[thread overview]
Message-ID: <FE751157F0442848A159F3AB4CB1F55B3D9FE8@039-SN1MPN1-001.039d.mgd.msft.net> (raw)

Hi,
I found an issue with the "info mem" command when running gdb on 32 bits host for 64 bits target architecture.
"info mem" command truncates the target address to 32 bits, like in the example below:

    (gdb) set architecture powerpc:common64
    The target architecture is assumed to be powerpc:common64
    (gdb) mem 0x100000000 0x200000000 rw
    (gdb) info mem
    Using user-defined memory regions.
    Num Enb Low Addr           High Addr          Attrs
    1   y   0x0000000000000000 0x0000000000000000 rw nocache

Please find below the proposed patch. Please let me know your comments.

Regards,
Catalin


Subject: [PATCHH] Fix info mem command for 32 bits host/64 bits target

When running gdb on 32 bits host for 64 bits target, info mem command
truncates the target address to 32 bits, like in the example below
	(gdb) set architecture powerpc:common64 
	(gdb) mem 0x100000000 0x200000000 rw
	(gdb) info mem
	1   y  	0x0000000000000000 0x0000000000000000 rw nocache 

Signed-off-by: Catalin Udma <catalin.udma@freescale.com>
---
--- gdb/memattr.c.orig	2013-06-27 17:28:20.000000000 +0300
+++ gdb/memattr.c	2013-06-27 17:29:16.000000000 +0300
@@ -447,9 +447,9 @@
 		       m->number,
 		       m->enabled_p ? 'y' : 'n');
       if (gdbarch_addr_bit (target_gdbarch ()) <= 32)
-	tmp = hex_string_custom ((unsigned long) m->lo, 8);
+	tmp = hex_string_custom ((LONGEST) m->lo, 8);
       else
-	tmp = hex_string_custom ((unsigned long) m->lo, 16);
+	tmp = hex_string_custom ( (LONGEST) m->lo, 16);
       
       printf_filtered ("%s ", tmp);
 
@@ -458,14 +458,14 @@
 	  if (m->hi == 0)
 	    tmp = "0x100000000";
 	  else
-	    tmp = hex_string_custom ((unsigned long) m->hi, 8);
+	    tmp = hex_string_custom ((LONGEST) m->hi, 8);
 	}
       else
 	{
 	  if (m->hi == 0)
 	    tmp = "0x10000000000000000";
 	  else
-	    tmp = hex_string_custom ((unsigned long) m->hi, 16);
+	    tmp = hex_string_custom ((LONGEST) m->hi, 16);
 	}
 
       printf_filtered ("%s ", tmp);



             reply	other threads:[~2013-06-26 15:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 15:10 Udma Catalin-Dan-B32721 [this message]
2013-06-26 16:07 ` Pedro Alves
2013-06-26 16:11   ` Pedro Alves
2013-06-26 16:17     ` Pedro Alves
2013-06-26 17:11     ` Tom Tromey
2013-06-26 16:20   ` Udma Catalin-Dan-B32721
2013-06-27  8:42   ` Udma Catalin-Dan-B32721
2013-06-27  8:44     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FE751157F0442848A159F3AB4CB1F55B3D9FE8@039-SN1MPN1-001.039d.mgd.msft.net \
    --to=b32721@freescale.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox