From: Tom Tromey <tromey@redhat.com>
To: Nicolas Blanc <nicolas.blanc@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
Date: Thu, 10 Oct 2013 20:31:00 -0000 [thread overview]
Message-ID: <874n8o6f66.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1381148820-21890-4-git-send-email-nicolas.blanc@intel.com> (Nicolas Blanc's message of "Mon, 7 Oct 2013 14:26:58 +0200")
>>>>> "Nicolas" == Nicolas Blanc <nicolas.blanc@intel.com> writes:
Nicolas> 2013-17-06 Nicolas Blanc <nicolas.blanc@intel.com>
Nicolas> * symfile.c (add_target_sections_of_objfile): New function.
Nicolas> (add_symbol_file_command): Update the current target sections.
Nicolas> (symfile_free_objfile): New function.
Nicolas> (_initialize_symfile): Attach observer for free_objfile.
Could you explain this one a bit?
Nicolas> +static void
Nicolas> +add_target_sections_of_objfile (struct objfile *objfile)
I'd like it better, I think, if some of the code in this function were
either moved to exec.c alongside the other target_sections-manipulating
functions, or just used them directly somehow.
Nicolas> + if (objfile->flags & OBJF_USERLOADED)
Needs an explicit "!= 0".
Tom
next prev parent reply other threads:[~2013-10-10 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 12:27 [PATCH v16 0/5] remove-symbol-file & add-symbol-file Nicolas Blanc
2013-10-07 12:27 ` [PATCH v16 4/5] Function is_elf_target Nicolas Blanc
2013-10-10 19:55 ` Tom Tromey
2013-10-07 12:27 ` [PATCH v16 2/5] Documentation for the remove-symbol-file command Nicolas Blanc
2013-10-07 12:27 ` [PATCH v16 1/5] New " Nicolas Blanc
2013-10-10 20:13 ` Tom Tromey
2013-10-07 12:27 ` [PATCH v16 3/5] 'add-symbol-file' should update the current target sections Nicolas Blanc
2013-10-10 20:31 ` Tom Tromey [this message]
2013-10-15 13:39 ` Blanc, Nicolas
2013-10-15 13:54 ` Tom Tromey
2013-10-07 12:27 ` [PATCH v16 5/5] Test adding and removing a symbol file at runtime Nicolas Blanc
2013-10-10 20:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n8o6f66.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=nicolas.blanc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox