From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32135 invoked by alias); 10 Oct 2013 20:31:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32123 invoked by uid 89); 10 Oct 2013 20:31:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 20:31:49 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKVldb027610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Oct 2013 16:31:47 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKVkd5027369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 10 Oct 2013 16:31:46 -0400 From: Tom Tromey To: Nicolas Blanc Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections. References: <1381148820-21890-1-git-send-email-nicolas.blanc@intel.com> <1381148820-21890-4-git-send-email-nicolas.blanc@intel.com> Date: Thu, 10 Oct 2013 20:31:00 -0000 In-Reply-To: <1381148820-21890-4-git-send-email-nicolas.blanc@intel.com> (Nicolas Blanc's message of "Mon, 7 Oct 2013 14:26:58 +0200") Message-ID: <874n8o6f66.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00368.txt.bz2 >>>>> "Nicolas" == Nicolas Blanc writes: Nicolas> 2013-17-06 Nicolas Blanc Nicolas> * symfile.c (add_target_sections_of_objfile): New function. Nicolas> (add_symbol_file_command): Update the current target sections. Nicolas> (symfile_free_objfile): New function. Nicolas> (_initialize_symfile): Attach observer for free_objfile. Could you explain this one a bit? Nicolas> +static void Nicolas> +add_target_sections_of_objfile (struct objfile *objfile) I'd like it better, I think, if some of the code in this function were either moved to exec.c alongside the other target_sections-manipulating functions, or just used them directly somehow. Nicolas> + if (objfile->flags & OBJF_USERLOADED) Needs an explicit "!= 0". Tom