Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Blanc, Nicolas" <nicolas.blanc@intel.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
Date: Tue, 15 Oct 2013 13:39:00 -0000	[thread overview]
Message-ID: <388084C8C1E6A64FA36AD1D656E4856624373405@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <874n8o6f66.fsf@fleche.redhat.com>


Thanks for the input. I am implementing your suggestions and will update the patch series next week. 

> Nicolas> +static void
> Nicolas> +add_target_sections_of_objfile (struct objfile *objfile)
>
> I'd like it better, I think, if some of the code in this function were either moved to exec.c alongside the other target_sections-manipulating functions, or just used them directly somehow.

I rewrote add_target_section_of_objfile using add_target_sections. The new code needs to construct on the heap a temporary array of target sections  for the sole purpose of
calling add_target_sections. This is not as neat as the original code in my view. I would prefer moving add_target_sections_of_objfile to exec.c. Would this be ok with you?

Regards,

Nicolas






Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


  reply	other threads:[~2013-10-15 13:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07 12:27 [PATCH v16 0/5] remove-symbol-file & add-symbol-file Nicolas Blanc
2013-10-07 12:27 ` [PATCH v16 1/5] New remove-symbol-file command Nicolas Blanc
2013-10-10 20:13   ` Tom Tromey
2013-10-07 12:27 ` [PATCH v16 2/5] Documentation for the " Nicolas Blanc
2013-10-07 12:27 ` [PATCH v16 4/5] Function is_elf_target Nicolas Blanc
2013-10-10 19:55   ` Tom Tromey
2013-10-07 12:27 ` [PATCH v16 5/5] Test adding and removing a symbol file at runtime Nicolas Blanc
2013-10-10 20:45   ` Tom Tromey
2013-10-07 12:27 ` [PATCH v16 3/5] 'add-symbol-file' should update the current target sections Nicolas Blanc
2013-10-10 20:31   ` Tom Tromey
2013-10-15 13:39     ` Blanc, Nicolas [this message]
2013-10-15 13:54       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=388084C8C1E6A64FA36AD1D656E4856624373405@IRSMSX106.ger.corp.intel.com \
    --to=nicolas.blanc@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox