From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24148 invoked by alias); 15 Oct 2013 13:39:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24134 invoked by uid 89); 15 Oct 2013 13:39:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2013 13:39:10 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by azsmga101.ch.intel.com with ESMTP; 15 Oct 2013 06:39:07 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 15 Oct 2013 06:39:07 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 15 Oct 2013 14:37:27 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.226]) by IRSMSX153.ger.corp.intel.com ([169.254.9.47]) with mapi id 14.03.0123.003; Tue, 15 Oct 2013 14:37:24 +0100 From: "Blanc, Nicolas" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections. Date: Tue, 15 Oct 2013 13:39:00 -0000 Message-ID: <388084C8C1E6A64FA36AD1D656E4856624373405@IRSMSX106.ger.corp.intel.com> References: <1381148820-21890-1-git-send-email-nicolas.blanc@intel.com> <1381148820-21890-4-git-send-email-nicolas.blanc@intel.com> <874n8o6f66.fsf@fleche.redhat.com> In-Reply-To: <874n8o6f66.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00454.txt.bz2 Thanks for the input. I am implementing your suggestions and will update th= e patch series next week.=20 > Nicolas> +static void > Nicolas> +add_target_sections_of_objfile (struct objfile *objfile) > > I'd like it better, I think, if some of the code in this function were ei= ther moved to exec.c alongside the other target_sections-manipulating funct= ions, or just used them directly somehow. I rewrote add_target_section_of_objfile using add_target_sections. The new = code needs to construct on the heap a temporary array of target sections f= or the sole purpose of calling add_target_sections. This is not as neat as the original code in my= view. I would prefer moving add_target_sections_of_objfile to exec.c. Woul= d this be ok with you? Regards, Nicolas Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052