From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Gabriel Krisman Bertazi <gabriel@krisman.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix PR gdb/17035: "show user" doesn't list user-defined commands that have empty bodies.
Date: Thu, 21 Aug 2014 21:20:00 -0000 [thread overview]
Message-ID: <874mx5pmkl.fsf@redhat.com> (raw)
In-Reply-To: <1408515134-31165-1-git-send-email-gabriel@krisman.be> (Gabriel Krisman Bertazi's message of "Wed, 20 Aug 2014 03:12:14 -0300")
On Wednesday, August 20 2014, Gabriel Krisman Bertazi wrote:
> diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
> index b415267..4c42ff1 100644
> --- a/gdb/cli/cli-cmds.c
> +++ b/gdb/cli/cli-cmds.c
> @@ -1245,9 +1245,8 @@ show_user (char *args, int from_tty)
> const char *comname = args;
>
> c = lookup_cmd (&comname, cmdlist, "", 0, 1);
> - /* c->user_commands would be NULL if it's a python/scheme command. */
> - if (c->class != class_user || !c->user_commands)
> - error (_("Not a user command."));
> + if (c->class != class_user)
> + error (_("Not a user command."));
^^^^^^^^
Missing TAB.
Minor-tiny nit.
Cheers,
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2014-08-21 21:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 6:12 Gabriel Krisman Bertazi
2014-08-21 15:53 ` Pedro Alves
2014-08-23 2:27 ` Gabriel Krisman Bertazi
2014-08-27 11:56 ` Pedro Alves
2014-08-31 18:35 ` Gabriel Krisman Bertazi
2014-09-02 12:52 ` Pedro Alves
2014-09-04 19:26 ` Gabriel Krisman Bertazi
2014-09-04 19:57 ` Sergio Durigan Junior
2014-09-05 13:12 ` Pedro Alves
2014-09-08 0:44 ` Gabriel Krisman Bertazi
2014-09-09 21:19 ` Sergio Durigan Junior
2014-08-21 21:20 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mx5pmkl.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gabriel@krisman.be \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox