From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9605 invoked by alias); 21 Aug 2014 21:20:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9584 invoked by uid 89); 21 Aug 2014 21:20:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Aug 2014 21:20:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7LLJteM011685 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Aug 2014 17:19:56 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7LLJtvV023137 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 21 Aug 2014 17:19:55 -0400 From: Sergio Durigan Junior To: Gabriel Krisman Bertazi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR gdb/17035: "show user" doesn't list user-defined commands that have empty bodies. References: <1408515134-31165-1-git-send-email-gabriel@krisman.be> X-URL: http://www.redhat.com Date: Thu, 21 Aug 2014 21:20:00 -0000 In-Reply-To: <1408515134-31165-1-git-send-email-gabriel@krisman.be> (Gabriel Krisman Bertazi's message of "Wed, 20 Aug 2014 03:12:14 -0300") Message-ID: <874mx5pmkl.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00493.txt.bz2 On Wednesday, August 20 2014, Gabriel Krisman Bertazi wrote: > diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c > index b415267..4c42ff1 100644 > --- a/gdb/cli/cli-cmds.c > +++ b/gdb/cli/cli-cmds.c > @@ -1245,9 +1245,8 @@ show_user (char *args, int from_tty) > const char *comname = args; > > c = lookup_cmd (&comname, cmdlist, "", 0, 1); > - /* c->user_commands would be NULL if it's a python/scheme command. */ > - if (c->class != class_user || !c->user_commands) > - error (_("Not a user command.")); > + if (c->class != class_user) > + error (_("Not a user command.")); ^^^^^^^^ Missing TAB. Minor-tiny nit. Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/