Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Marco Barisione <mbarisione@undo.io>
Cc: Kevin Buettner <kevinb@redhat.com>,
	 gdb-patches@sourceware.org,  Eli Zaretskii <eliz@gnu.org>,
	 Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v3] Add gdb.Value.format_string ()
Date: Wed, 27 Mar 2019 20:16:00 -0000	[thread overview]
Message-ID: <874l7om5sh.fsf@tromey.com> (raw)
In-Reply-To: <0905920C-D564-4505-B42E-522F1BB95397@undo.io> (Marco Barisione's	message of "Mon, 18 Mar 2019 18:17:03 +0000")

>>>>> "Marco" == Marco Barisione <mbarisione@undo.io> writes:

Hi.  I apologize for the delay on this.  I am rather behind.

I only have two nits with this patch.  The rest looks very good, thank
you for doing this.

Marco> +  static const char *keywords[] = {

I think the brace should be on a new line.

Marco> +      NULL };

Here too.


This is ok with these changed.

Tom


  reply	other threads:[~2019-03-27 20:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 11:18 [PATCH] " Marco Barisione
2019-03-17 20:50 ` Kevin Buettner
2019-03-17 23:41   ` Marco Barisione
2019-03-18  9:22   ` [PATCH v2] " Marco Barisione
2019-03-18 16:34     ` Kevin Buettner
2019-03-18 17:49       ` Eli Zaretskii
2019-03-18 18:17       ` [PATCH v3] " Marco Barisione
2019-03-27 20:16         ` Tom Tromey [this message]
2019-03-28 13:55           ` [PATCH v4] " Marco Barisione
2019-03-29 15:03             ` Tom Tromey
2019-04-12 20:18             ` New failures on gdb.python/py-format-string.exp - unix/-m32 (was: Re: [PATCH v4] Add gdb.Value.format_string ()) Sergio Durigan Junior
     [not found]       ` <D8FDF6CA-2755-4AC2-BE63-A76311F566E6@undo.io>
2019-03-18 20:00         ` [PATCH v3] Add gdb.Value.format_string () Eli Zaretskii
2019-03-18 21:49           ` [PATCH v4] " Marco Barisione
2019-03-19  6:48             ` Eli Zaretskii
2019-03-26 12:07             ` [PING][PATCH " Marco Barisione
2019-03-18 17:49     ` [PATCH v2] " Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l7om5sh.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=mbarisione@undo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox