Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Marco Barisione <mbarisione@undo.io>
Cc: Tom Tromey <tom@tromey.com>,  Kevin Buettner <kevinb@redhat.com>,
	 gdb-patches@sourceware.org,  Eli Zaretskii <eliz@gnu.org>
Subject: New failures on gdb.python/py-format-string.exp - unix/-m32 (was: Re: [PATCH v4] Add gdb.Value.format_string ())
Date: Fri, 12 Apr 2019 20:18:00 -0000	[thread overview]
Message-ID: <87y34fdljv.fsf_-_@redhat.com> (raw)
In-Reply-To: <6B4C3808-7D1A-46E2-A4B4-50186779B9B0@undo.io> (Marco Barisione's	message of "Thu, 28 Mar 2019 13:54:57 +0000")

On Thursday, March 28 2019, Marco Barisione wrote:

> On 27 Mar 2019, at 20:16, Tom Tromey <tom@tromey.com> wrote:
>> I only have two nits with this patch.  The rest looks very good, thank
>> you for doing this.
>
> Thanks!
>
> I’ve attached a patch which is identical to the previous one except for:
> * Indentation fixed;
> * The NEWS file update was moved to the “Since GDB 8.3” section;
> * Test fixed to not expect a stray space between a comma and a newline
>   any more (as the original behaviour was fixed by Andrew Burgess a few
>   days ago).

Hi Marco,

The new test FAILs when tested on x86_64 with -m32.  I.e.,:

  make check-gdb TESTS=gdb.python/py-format-string.exp RUNTESTFLAGS='--target_board unix/-m32'

The failures I'm seeing:

  python print (gdb.parse_and_eval ('a_base_ref').format_string (deref_refs=True))
  @0xffffbb98: {_vptr.Base = 0x80487a4 <vtable for Deriv+8>, a = 42, static a_static_member = 2019}
  (gdb) FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: a_base_ref with option deref_refs: deref_refs=true
  ...
  python print (gdb.parse_and_eval ('a_base_ref').format_string (deref_refs=True, static_members=False))
  @0xffffbb98: {_vptr.Base = 0x80487a4 <vtable for Deriv+8>, a = 42}
  (gdb) FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: a_base_ref with option deref_refs=True, static_members=False

Here is the BuildBot run:

  https://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/12191

And the logs:

  https://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/52/52093e1b936fa4f3f8bb3868c5a44d0df25c8db4/

Let me know if you need help investigating these.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


  parent reply	other threads:[~2019-04-12 20:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 11:18 [PATCH] Add gdb.Value.format_string () Marco Barisione
2019-03-17 20:50 ` Kevin Buettner
2019-03-17 23:41   ` Marco Barisione
2019-03-18  9:22   ` [PATCH v2] " Marco Barisione
2019-03-18 16:34     ` Kevin Buettner
2019-03-18 17:49       ` Eli Zaretskii
2019-03-18 18:17       ` [PATCH v3] " Marco Barisione
2019-03-27 20:16         ` Tom Tromey
2019-03-28 13:55           ` [PATCH v4] " Marco Barisione
2019-03-29 15:03             ` Tom Tromey
2019-04-12 20:18             ` Sergio Durigan Junior [this message]
     [not found]       ` <D8FDF6CA-2755-4AC2-BE63-A76311F566E6@undo.io>
2019-03-18 20:00         ` [PATCH v3] " Eli Zaretskii
2019-03-18 21:49           ` [PATCH v4] " Marco Barisione
2019-03-19  6:48             ` Eli Zaretskii
2019-03-26 12:07             ` [PING][PATCH " Marco Barisione
2019-03-18 17:49     ` [PATCH v2] " Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y34fdljv.fsf_-_@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=mbarisione@undo.io \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox