From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25308 invoked by alias); 27 Mar 2019 20:16:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25299 invoked by uid 89); 27 Mar 2019 20:16:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.180.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Mar 2019 20:16:49 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 6A239115F0 for ; Wed, 27 Mar 2019 15:16:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9EydhlPoMdnCe9Eydhc3WJ; Wed, 27 Mar 2019 15:16:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1ipETk9F2Rz8rdUy9zbjyVvDcHHR3APraHuhYCKBVUU=; b=NGW+x4YhvTsuhinh7SfMRkMo19 HMjcR+fKW+ftPiMjt8+lsoj81g0UVA6yeDJa/qPBW5LlTmrlXTpKGFZHb2VFCWf33s4NMSGIyJ+EZ JXf/5UMKRkh5Rt9Vu0/scmsL7; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:42248 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h9Eyd-000EZv-3Z; Wed, 27 Mar 2019 15:16:47 -0500 From: Tom Tromey To: Marco Barisione Cc: Kevin Buettner , gdb-patches@sourceware.org, Eli Zaretskii , Tom Tromey Subject: Re: [PATCH v3] Add gdb.Value.format_string () References: <20190317135023.2e51944d@f29-4.lan> <20190318093441.641ca394@f29-4.lan> <0905920C-D564-4505-B42E-522F1BB95397@undo.io> Date: Wed, 27 Mar 2019 20:16:00 -0000 In-Reply-To: <0905920C-D564-4505-B42E-522F1BB95397@undo.io> (Marco Barisione's message of "Mon, 18 Mar 2019 18:17:03 +0000") Message-ID: <874l7om5sh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00645.txt.bz2 >>>>> "Marco" == Marco Barisione writes: Hi. I apologize for the delay on this. I am rather behind. I only have two nits with this patch. The rest looks very good, thank you for doing this. Marco> + static const char *keywords[] = { I think the brace should be on a new line. Marco> + NULL }; Here too. This is ok with these changed. Tom