Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix Ada val_print removal regression
Date: Thu, 19 Mar 2020 07:54:45 -0600	[thread overview]
Message-ID: <874kuksb4q.fsf@tromey.com> (raw)
In-Reply-To: <6a432b2a-4ae9-101d-32c3-efee7da031d1@simark.ca> (Simon Marchi's message of "Tue, 17 Mar 2020 21:31:38 -0400")

Simon> While checking this, I noticed that the `struct value *`
Simon> parameters of print_field_values and print_variant_part appear to
Simon> be unnecessary.  They are only passed recursively, but never
Simon> actually used.

Thanks

Simon> But most importantly, I was thinking that this
Simon> ada_val_print_struct_union function looked like it was accepting
Simon> a decomposed struct value, much like the API that you have
Simon> removed.  Would it work and be good to change it to work more
Simon> with `struct value`s?  It seems to me like this bug would have
Simon> been avoided.

Yeah.  The val_print removal series neglected a few spots.  I will try
to see if this one can be easily changed.

Tom


  reply	other threads:[~2020-03-19 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 18:00 Tom Tromey
2020-03-18  1:31 ` Simon Marchi
2020-03-19 13:54   ` Tom Tromey [this message]
2020-03-19 19:42     ` Tom Tromey
2020-03-19 20:19       ` Simon Marchi
2020-03-19 21:13         ` Tom Tromey
2020-03-19 21:24           ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kuksb4q.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox