From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix Ada val_print removal regression
Date: Thu, 19 Mar 2020 17:24:44 -0400 [thread overview]
Message-ID: <6e0acd7d-a2a0-627d-ef3b-9abf0dc35687@simark.ca> (raw)
In-Reply-To: <87zhccnj42.fsf@tromey.com>
On 2020-03-19 5:13 p.m., Tom Tromey wrote:
>>> + struct value *variant = value_field (value, which);
>
> Simon> A bit of a nit, but it's to make sure I understand what's
> Simon> happening. From what I understand, the variant is the enclosing
> Simon> type, from which only one component is active at a given time.
> Simon> This value variable represents the active component, right?
>
> Yep.
>
> Simon> If
> Simon> so, I'd suggest naming it active_component or something like
> Simon> that.
>
> Done.
>
> Simon> The sole caller of this function passes the same `val` twice, so
> Simon> I suppose you could remove `original_value`.
>
> I did this too.
>
> Tom
Thanks, I think this is fine.
Simon
prev parent reply other threads:[~2020-03-19 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 18:00 Tom Tromey
2020-03-18 1:31 ` Simon Marchi
2020-03-19 13:54 ` Tom Tromey
2020-03-19 19:42 ` Tom Tromey
2020-03-19 20:19 ` Simon Marchi
2020-03-19 21:13 ` Tom Tromey
2020-03-19 21:24 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0acd7d-a2a0-627d-ef3b-9abf0dc35687@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox