From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix Ada val_print removal regression
Date: Tue, 17 Mar 2020 21:31:38 -0400 [thread overview]
Message-ID: <6a432b2a-4ae9-101d-32c3-efee7da031d1@simark.ca> (raw)
In-Reply-To: <20200317180034.26934-1-tromey@adacore.com>
On 2020-03-17 2:00 p.m., Tom Tromey wrote:
> @@ -595,6 +595,7 @@ print_variant_part (struct type *type, int field_num,
>
> static int
> print_field_values (struct type *type, const gdb_byte *valaddr,
The comment of this function would need to be updated.
While checking this, I noticed that the `struct value *` parameters of print_field_values
and print_variant_part appear to be unnecessary. They are only passed recursively, but
never actually used.
But most importantly, I was thinking that this ada_val_print_struct_union function looked
like it was accepting a decomposed struct value, much like the API that you have removed.
Would it work and be good to change it to work more with `struct value`s? It seems to me
like this bug would have been avoided.
Simon
next prev parent reply other threads:[~2020-03-18 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 18:00 Tom Tromey
2020-03-18 1:31 ` Simon Marchi [this message]
2020-03-19 13:54 ` Tom Tromey
2020-03-19 19:42 ` Tom Tromey
2020-03-19 20:19 ` Simon Marchi
2020-03-19 21:13 ` Tom Tromey
2020-03-19 21:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a432b2a-4ae9-101d-32c3-efee7da031d1@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox