Re: [PATCH] [gdb/tui] Handle error in tui_enable

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Say we simulate an error:
Tom> ...

Is there a way that this can happen without simulation?

I'm asking because:

Tom> Note that this doesn't allow a second attempt:
Tom> ...
Tom> $ gdb -q
Tom> (gdb) tui enable
Tom> ❌️ Oh no!!!
Tom> (gdb) tui enable
Tom> ❌️ Cannot enable the TUI
Tom> (gdb)
Tom> ...
Tom> because tui_finish_init is stuck at TRIBOOL_UNKNOWN.

Tom> IWBN to fix this in a way that allows the second "tui enable" to succeed.  I
Tom> tried this for a bit, but didn't get it to work.

If this can occur due to some user problem (say a bad layout or bad
window implementation) then gdb ideally should be more robust somehow.

But OTOH if this is something that's really obscure, what you have seems
totally fine.

Anyway I think the patch itself is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom