From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mxKGCee/8GneIwEAWB0awg (envelope-from ) for ; Tue, 28 Apr 2026 10:10:47 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HPAEq7ig; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 12F4D1E067; Tue, 28 Apr 2026 10:10:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4BAB91E067 for ; Tue, 28 Apr 2026 10:10:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 920A04BB8F4B for ; Tue, 28 Apr 2026 14:10:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 920A04BB8F4B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HPAEq7ig Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 9DFC54BA23F0 for ; Tue, 28 Apr 2026 14:10:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DFC54BA23F0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DFC54BA23F0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777385420; cv=none; b=E1aBuYN8P/jGClEQHf4W2AlWERrZjCI8r6caiNbZ6NGat4LCXS8l6xZf/xvB6/fq3qkgIJb5GIpQn9V5PNqzwWV1gKIlrJrBXlPVZQxox8eUASPC1w+CyP58sYgAoVnrPFuxtAlJlOHU8yKpYZYIrQYKOqmtrefl2FZ9Lf5mYGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777385420; c=relaxed/simple; bh=q4MQvutSgDXqRqvuyWFN6bRnjHoUrdytFm2VoSHVyCc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BZvQJ7am416g7RSTB3psUAPOj2k1Dca8eCQ6dHav2xR8xJ3MIt+PWSHyoRw/YNql4WgYvQ2yMIy857hIux5aJ0KXp59XtvQSmcoIRcGAX0VhUhcZkQpr9xC1ovnswCxBVz1wNqdZL1jN8UoLt1ZdJ3fP0TKylMP+mLOeHvq+tIE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9DFC54BA23F0 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id HVRXwqtCr4RkpHj8mwIUvd; Tue, 28 Apr 2026 14:10:20 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Hj8hwfAEgWrBXHj8hwykR7; Tue, 28 Apr 2026 14:10:15 +0000 X-Authority-Analysis: v=2.4 cv=ALkt6GG8 c=1 sm=1 tr=0 ts=69f0bfcb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=ExZFzgmx-ofmXilcLLMA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=zZCYzV9kfG8A:10 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fkMPMF6eIV3MK2hIF1y22Ovxx/oMVEYfLYOZ4EipBP4=; b=HPAEq7igwomEiMTMt6H1ToVpwa 3W0XPyKpCWmkkACsH2fFXMzDTNh4xTP/LXaGz0wXcU5wNX3mXjxcngp81BWrt0t0OjUuq+ElbYvHM 3AyIBDJi0G2d8XL2+bs0P9o2l; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:33354 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wHj8h-00000000ruz-0Ma4; Tue, 28 Apr 2026 08:10:15 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Handle error in tui_enable In-Reply-To: <20260424154942.50673-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 24 Apr 2026 17:49:42 +0200") References: <20260424154942.50673-1-tdevries@suse.de> X-Attribution: Tom Date: Tue, 28 Apr 2026 08:10:13 -0600 Message-ID: <874ikvnpkq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wHj8h-00000000ruz-0Ma4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:33354 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPOBkkdFudmC0psk5l1y1SP+y8nQGtzsYqpsePHQbmv+pKA6f0owbz3iKTHcgAKQS+gud1mfp5cgUC0nNcdleI6ztp9rFjajNpGn3rA+qgq6XP9CgF7u tWXja2V3XMpwlIZgH5p32mELqOqsFSuhS4XpR5o+TUzmF0iMjgcrjjnZZh60wbueJIhOZFtX0xLj66kErhwDOlmC5G3/O5N0pi0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" =3D=3D Tom de Vries writes: Tom> Say we simulate an error: Tom> ... Is there a way that this can happen without simulation? I'm asking because: Tom> Note that this doesn't allow a second attempt: Tom> ... Tom> $ gdb -q Tom> (gdb) tui enable Tom> =E2=9D=8C=EF=B8=8F Oh no!!! Tom> (gdb) tui enable Tom> =E2=9D=8C=EF=B8=8F Cannot enable the TUI Tom> (gdb) Tom> ... Tom> because tui_finish_init is stuck at TRIBOOL_UNKNOWN. Tom> IWBN to fix this in a way that allows the second "tui enable" to succe= ed. I Tom> tried this for a bit, but didn't get it to work. If this can occur due to some user problem (say a bad layout or bad window implementation) then gdb ideally should be more robust somehow. But OTOH if this is something that's really obscure, what you have seems totally fine. Anyway I think the patch itself is ok. Approved-By: Tom Tromey Tom