Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/tui] Handle error in tui_enable
Date: Wed, 29 Apr 2026 13:14:57 +0200	[thread overview]
Message-ID: <75bb7e96-1649-4fc7-8431-7526dae117ea@suse.de> (raw)
In-Reply-To: <da046dd8-f32f-4d20-92ed-732dbfbc1066@suse.de>

On 4/28/26 11:42 PM, Tom de Vries wrote:
> On 4/28/26 4:10 PM, Tom Tromey wrote:
>> Tom> IWBN to fix this in a way that allows the second "tui enable" to 
>> succeed.  I
>> Tom> tried this for a bit, but didn't get it to work.
>>
>> If this can occur due to some user problem (say a bad layout or bad
>> window implementation) then gdb ideally should be more robust somehow.
> 
> OK, I've got a theory why I had difficulty getting this to work.
> 
> The problem is probably that after endwin "Refreshing a window resumes 
> program mode" and I suppose that got triggered by "tui_batch_rendering 
> defer".
> 
> So using an explicit reset_shell_mode instead of endwin makes this work 
> for me.
> 

I've submitted a patch series that fixes this ( 
https://sourceware.org/pipermail/gdb-patches/2026-April/226966.html ).

Thanks,
- Tom


      reply	other threads:[~2026-04-29 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 15:49 Tom de Vries
2026-04-28 14:10 ` Tom Tromey
2026-04-28 21:42   ` Tom de Vries
2026-04-29 11:14     ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75bb7e96-1649-4fc7-8431-7526dae117ea@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox