From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ade4NE3o8Wl9FQMAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 07:15:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=PA817d31; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bItJWzb5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=URehJglh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9LQdAS7A; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D39351E0BA; Wed, 29 Apr 2026 07:15:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 35A461E067 for ; Wed, 29 Apr 2026 07:15:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id CE1814BB24C9 for ; Wed, 29 Apr 2026 11:15:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE1814BB24C9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=PA817d31; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bItJWzb5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=URehJglh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9LQdAS7A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 3D6BB4BB24E1 for ; Wed, 29 Apr 2026 11:15:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D6BB4BB24E1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D6BB4BB24E1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777461300; cv=none; b=Wf2Y90MyfLtBHg+V6yTHs+J44kotJAbhMDvA+3Eeof13zpc5uicUn36XcQIjYpUGDbKYIz4/9wqnDY8toMRw3pP7Q2w99UGxJu/hzbLEv01WBT/0MSeu2cYLduKo6LCXUPa/Ohu1LGwhLQD8lgDkFmIZUheENjMnjoUw/XhUAHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777461300; c=relaxed/simple; bh=cMRz4bUJL6Wpfb246sStJgyNGkbmGH2eFHXm3Y9AQL8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=PwpR9Wj0sAj/85Fws2FB55GU1/cvJz+ZXfQWtPiIJtX6ZHNLIndPUh4UsI/UJ3ofM7y6sJAyti5JsrL4rRlopaeKDnEViovEsIK7FuxTyTJLRlbHnqvsvA8mlDAqAO2ZJc5RY3o9OTx4lqa7t3ZZlDT5McfodKaTV6XOxU7nKp4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D6BB4BB24E1 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 264C36A864; Wed, 29 Apr 2026 11:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777461299; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aoHcFhokfRF6U/yjaePkr8WyF6XzW+Drim3lj/M8YtU=; b=PA817d31rpdiFWZCBk249lrh3GuvW/S0qbwzgtUTOv1LnuIA6v9Gce81ymh5vUuDyJQMDN 5nMfZVXYyhm5l1qHBQZdfVLvJn6LItSaryfEHzjccQ2Od0cj6TMR44tVPoo67F4yaq96qb 5jUOkx2y8zueOc7SbWBSfXQREByOmlY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777461299; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aoHcFhokfRF6U/yjaePkr8WyF6XzW+Drim3lj/M8YtU=; b=bItJWzb5I1cI16vYkDws1t0lsoo7fqZ+7xtfLBsEIbsP3F1VEOl/qLB5oIJZbauZGY7xZs liGyL324WDJm/CAw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777461298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aoHcFhokfRF6U/yjaePkr8WyF6XzW+Drim3lj/M8YtU=; b=URehJglhJsUkZsm1CBdFY1ZaHkQ3Wtq14iCgpkUu6YsLXxtPGMqadt3ZVGhme0KIBR6cyW rp+Zb+4d5YprR0n3DzvyE+3gaeM74ZY+XEvYNZipCKTAG1pgMBM6AF2HT7tBmk/z/SePu+ 4pRNlCajsxshhZb2HGN433qdIfcl1xU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777461298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aoHcFhokfRF6U/yjaePkr8WyF6XzW+Drim3lj/M8YtU=; b=9LQdAS7AkC2tJxipQU1EVBnMU7D8YgVl+ewupNiHyQn2/rVhFoTJIJ0mQrvzaCFshCctR2 uynUasvl5PSrFsDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 10164593B0; Wed, 29 Apr 2026 11:14:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id s6mvAjLo8WnyIQAAD6G6ig (envelope-from ); Wed, 29 Apr 2026 11:14:58 +0000 Message-ID: <75bb7e96-1649-4fc7-8431-7526dae117ea@suse.de> Date: Wed, 29 Apr 2026 13:14:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Handle error in tui_enable From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260424154942.50673-1-tdevries@suse.de> <874ikvnpkq.fsf@tromey.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, sourceware.org:url, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/26 11:42 PM, Tom de Vries wrote: > On 4/28/26 4:10 PM, Tom Tromey wrote: >> Tom> IWBN to fix this in a way that allows the second "tui enable" to >> succeed.  I >> Tom> tried this for a bit, but didn't get it to work. >> >> If this can occur due to some user problem (say a bad layout or bad >> window implementation) then gdb ideally should be more robust somehow. > > OK, I've got a theory why I had difficulty getting this to work. > > The problem is probably that after endwin "Refreshing a window resumes > program mode" and I suppose that got triggered by "tui_batch_rendering > defer". > > So using an explicit reset_shell_mode instead of endwin makes this work > for me. > I've submitted a patch series that fixes this ( https://sourceware.org/pipermail/gdb-patches/2026-April/226966.html ). Thanks, - Tom