From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 9/9] enable target-async
Date: Wed, 31 Jul 2013 20:26:00 -0000 [thread overview]
Message-ID: <8738quiigr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20985.29045.586199.345765@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 31 Jul 2013 13:20:05 -0700")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>> +int mi_last_was_cli;
>> +
Doug> Delete? It's declared in mi-main.h.
Yeah. Sorry about this, I forgot to zap some old hacks I had been
trying out. Hence the commented-out code and other goo.
>> + if (!target_is_async_p () || !sync_execution)
Doug> Please add a comment explaining the condition here.
Doug> It loosely reads as !async || async.
Ok.
>> struct cleanup *back_to = make_cleanup_restore_integer (&sched_multi);
>>
>> + if (!target_async_permitted && target_can_async_p ())
>> + async_disable_stdin ();
>> +
Doug> A comment explaining why this is here would be helpful.
Doug> I thought target_can_async_p was just a capability flag, not something
Doug> specifying the current state of anything.
This mirrors a condition elsewhere.
I'll add a comment.
Tom
next prev parent reply other threads:[~2013-07-31 20:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 18:28 [PATCH v2 0/9] enable target-async by default Tom Tromey
2013-07-31 18:28 ` [PATCH v2 1/9] fix latent bugs in ui-out.c Tom Tromey
2013-07-31 18:28 ` [PATCH v2 4/9] PR gdb/13860: make -interpreter-exec console "list" behave more like "list" Tom Tromey
2013-07-31 18:28 ` [PATCH v2 7/9] make dprintf.exp pass in always-async mode Tom Tromey
2013-07-31 18:28 ` [PATCH v2 6/9] PR gdb/13860: don't lose '-interpreter-exec console EXECUTION_COMMAND''s output in async mode Tom Tromey
2013-07-31 18:28 ` [PATCH v2 5/9] PR gdb/13860: make "-exec-foo"'s MI output equal to "foo"'s MI output Tom Tromey
2013-07-31 18:28 ` [PATCH v2 9/9] enable target-async Tom Tromey
2013-07-31 20:20 ` Doug Evans
2013-07-31 20:26 ` Tom Tromey [this message]
2013-08-01 8:34 ` Yao Qi
2013-08-01 15:47 ` Tom Tromey
2013-08-02 19:26 ` Tom Tromey
2013-07-31 18:28 ` [PATCH v2 8/9] fix py-finish-breakpoint.exp with always-async Tom Tromey
2013-07-31 19:41 ` Doug Evans
2013-07-31 18:28 ` [PATCH v2 3/9] add target method delegation Tom Tromey
2013-07-31 18:28 ` [PATCH v2 2/9] add "this" pointers to more target APIs Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738quiigr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox