From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5071 invoked by alias); 31 Jul 2013 20:26:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5046 invoked by uid 89); 31 Jul 2013 20:26:56 -0000 X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 31 Jul 2013 20:26:56 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6VKQkfM016025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 31 Jul 2013 16:26:47 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6VKQjgQ012789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 31 Jul 2013 16:26:45 -0400 From: Tom Tromey To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 9/9] enable target-async References: <1375295281-7040-1-git-send-email-tromey@redhat.com> <1375295281-7040-10-git-send-email-tromey@redhat.com> <20985.29045.586199.345765@ruffy.mtv.corp.google.com> Date: Wed, 31 Jul 2013 20:26:00 -0000 In-Reply-To: <20985.29045.586199.345765@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 31 Jul 2013 13:20:05 -0700") Message-ID: <8738quiigr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00843.txt.bz2 >>>>> "Doug" == Doug Evans writes: >> +int mi_last_was_cli; >> + Doug> Delete? It's declared in mi-main.h. Yeah. Sorry about this, I forgot to zap some old hacks I had been trying out. Hence the commented-out code and other goo. >> + if (!target_is_async_p () || !sync_execution) Doug> Please add a comment explaining the condition here. Doug> It loosely reads as !async || async. Ok. >> struct cleanup *back_to = make_cleanup_restore_integer (&sched_multi); >> >> + if (!target_async_permitted && target_can_async_p ()) >> + async_disable_stdin (); >> + Doug> A comment explaining why this is here would be helpful. Doug> I thought target_can_async_p was just a capability flag, not something Doug> specifying the current state of anything. This mirrors a condition elsewhere. I'll add a comment. Tom