From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 9/9] enable target-async
Date: Thu, 01 Aug 2013 08:34:00 -0000 [thread overview]
Message-ID: <51FA1D7A.2010100@codesourcery.com> (raw)
In-Reply-To: <1375295281-7040-10-git-send-email-tromey@redhat.com>
On 08/01/2013 02:28 AM, Tom Tromey wrote:
> +/* Flag indicating whether the most recent command was executed via
> + the CLI interpreter. */
> +int mi_last_was_cli;
> +
In patch 6/9, a new field 'command_interp' is added to 'struct
thread_control_state', as below,
> +
> + /* The interpreter that issued the execution command. NULL if the
> + thread was resumed as a result of a command applied to some other
> + thread (e.g., "next" with scheduler-locking off). */
> + struct interp *command_interp;
looks we can iterate over all threads, to check field command_interp to
know what interpreter is used by the previous command (assuming that
there should be only one thread whose command_interp is not NULL), so
that this flag 'mi_last_was_cli' can be removed?
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-08-01 8:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 18:28 [PATCH v2 0/9] enable target-async by default Tom Tromey
2013-07-31 18:28 ` [PATCH v2 1/9] fix latent bugs in ui-out.c Tom Tromey
2013-07-31 18:28 ` [PATCH v2 5/9] PR gdb/13860: make "-exec-foo"'s MI output equal to "foo"'s MI output Tom Tromey
2013-07-31 18:28 ` [PATCH v2 6/9] PR gdb/13860: don't lose '-interpreter-exec console EXECUTION_COMMAND''s output in async mode Tom Tromey
2013-07-31 18:28 ` [PATCH v2 4/9] PR gdb/13860: make -interpreter-exec console "list" behave more like "list" Tom Tromey
2013-07-31 18:28 ` [PATCH v2 7/9] make dprintf.exp pass in always-async mode Tom Tromey
2013-07-31 18:28 ` [PATCH v2 8/9] fix py-finish-breakpoint.exp with always-async Tom Tromey
2013-07-31 19:41 ` Doug Evans
2013-07-31 18:28 ` [PATCH v2 2/9] add "this" pointers to more target APIs Tom Tromey
2013-07-31 18:28 ` [PATCH v2 3/9] add target method delegation Tom Tromey
2013-07-31 18:28 ` [PATCH v2 9/9] enable target-async Tom Tromey
2013-07-31 20:20 ` Doug Evans
2013-07-31 20:26 ` Tom Tromey
2013-08-01 8:34 ` Yao Qi [this message]
2013-08-01 15:47 ` Tom Tromey
2013-08-02 19:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA1D7A.2010100@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox