From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7660 invoked by alias); 1 Aug 2013 08:34:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7629 invoked by uid 89); 1 Aug 2013 08:34:52 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_05,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 08:34:52 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1V4oLL-0007Xc-4T from Yao_Qi@mentor.com ; Thu, 01 Aug 2013 01:34:43 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 1 Aug 2013 01:34:43 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Thu, 1 Aug 2013 01:34:42 -0700 Message-ID: <51FA1D7A.2010100@codesourcery.com> Date: Thu, 01 Aug 2013 08:34:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH v2 9/9] enable target-async References: <1375295281-7040-1-git-send-email-tromey@redhat.com> <1375295281-7040-10-git-send-email-tromey@redhat.com> In-Reply-To: <1375295281-7040-10-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00006.txt.bz2 On 08/01/2013 02:28 AM, Tom Tromey wrote: > +/* Flag indicating whether the most recent command was executed via > + the CLI interpreter. */ > +int mi_last_was_cli; > + In patch 6/9, a new field 'command_interp' is added to 'struct thread_control_state', as below, > + > + /* The interpreter that issued the execution command. NULL if the > + thread was resumed as a result of a command applied to some other > + thread (e.g., "next" with scheduler-locking off). */ > + struct interp *command_interp; looks we can iterate over all threads, to check field command_interp to know what interpreter is used by the previous command (assuming that there should be only one thread whose command_interp is not NULL), so that this flag 'mi_last_was_cli' can be removed? -- Yao (齐尧)