Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [RFA 2/4] Remove cmd_cfunc_ftype
Date: Mon, 06 Nov 2017 16:39:00 -0000	[thread overview]
Message-ID: <87375r1hvm.fsf@tromey.com> (raw)
In-Reply-To: <20171106115822.GB318@1170ee0b50d5> (Yao Qi's message of "Mon, 6	Nov 2017 11:58:22 +0000")

>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:

Yao> On 17-10-15 21:22:37, Tom Tromey wrote:
>> This removes cmd_cfunc_ftype and the non-const overload of add_cmd;
>> then fixes up the fallout.
>> 
>> For the most part this patch is straightforward.  There are a few
>> files (go32-nat.c, windows-nat.c, and gnu-nat.c) that I could not
>> compile; so I made a best effort there.
>> 

Yao> You can use x86_64-w64-mingw32 cross compiler to verify your changes
Yao> in windows-nat.c at least.

Thanks for the reminder.  I did that and it compiled fine.
However this series is based on an earlier one, so I won't be checking
it in until that is complete.

thanks,
Tom


  reply	other threads:[~2017-11-06 16:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  3:22 [RFA 0/4] finish command constification Tom Tromey
2017-10-16  3:22 ` [RFA 2/4] Remove cmd_cfunc_ftype Tom Tromey
2017-11-06 11:58   ` Yao Qi
2017-11-06 16:39     ` Tom Tromey [this message]
2017-10-16  3:23 ` [RFA 4/4] Constify execute_command Tom Tromey
2017-10-16  3:23 ` [RFA 1/4] Constify add_info Tom Tromey
2017-10-16  3:23 ` [RFA 3/4] Constify add_setshow_* Tom Tromey
2017-11-05 16:52 ` [RFA 0/4] finish command constification Tom Tromey
2017-11-06 12:03 ` Yao Qi
2017-11-07 20:55   ` Tom Tromey
2017-11-08  9:50     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87375r1hvm.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox