From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76676 invoked by alias); 6 Nov 2017 16:39:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76666 invoked by uid 89); 6 Nov 2017 16:39:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.193.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Nov 2017 16:39:27 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 5D6BD13D5F for ; Mon, 6 Nov 2017 10:39:26 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BkQoe5TcwtuxmBkQoeSa4z; Mon, 06 Nov 2017 10:39:26 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:51746 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eBkQo-003Sjb-3x; Mon, 06 Nov 2017 10:39:26 -0600 From: Tom Tromey To: Yao Qi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/4] Remove cmd_cfunc_ftype References: <20171016032239.24561-1-tom@tromey.com> <20171016032239.24561-3-tom@tromey.com> <20171106115822.GB318@1170ee0b50d5> Date: Mon, 06 Nov 2017 16:39:00 -0000 In-Reply-To: <20171106115822.GB318@1170ee0b50d5> (Yao Qi's message of "Mon, 6 Nov 2017 11:58:22 +0000") Message-ID: <87375r1hvm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eBkQo-003Sjb-3x X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo) [71.218.90.63]:51746 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-11/txt/msg00117.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> On 17-10-15 21:22:37, Tom Tromey wrote: >> This removes cmd_cfunc_ftype and the non-const overload of add_cmd; >> then fixes up the fallout. >> >> For the most part this patch is straightforward. There are a few >> files (go32-nat.c, windows-nat.c, and gnu-nat.c) that I could not >> compile; so I made a best effort there. >> Yao> You can use x86_64-w64-mingw32 cross compiler to verify your changes Yao> in windows-nat.c at least. Thanks for the reminder. I did that and it compiled fine. However this series is based on an earlier one, so I won't be checking it in until that is complete. thanks, Tom