From: Yao Qi <qiyaoltc@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 0/4] finish command constification
Date: Mon, 06 Nov 2017 12:03:00 -0000 [thread overview]
Message-ID: <20171106120350.GC318@1170ee0b50d5> (raw)
In-Reply-To: <20171016032239.24561-1-tom@tromey.com>
On 17-10-15 21:22:35, Tom Tromey wrote:
> This series completes my command constification efforts. This turned
> out to be much simpler than I had anticipated; partly because I
> started automating some of the changes, and partly because C++ makes
> some incremental refactorings simpler -- as discussed before, in this
> case by allowing the introduction of const overloads.
Thanks for the efforts.
>
> This series touches some files I can't compile. I made a best effort
> to inspect them for const correctness; but it's hard to be sure.
> Given the experience of this series as a whole, I think it is safe to
> say that any required changes will be minimal.
I gave a comment about using x86_64-w64-mingw32 cross compiler to verify
the changes in windows-nat.c. If the build is OK, this patch series
is good to me.
--
Yao (é½å°§)
next prev parent reply other threads:[~2017-11-06 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 3:22 Tom Tromey
2017-10-16 3:22 ` [RFA 2/4] Remove cmd_cfunc_ftype Tom Tromey
2017-11-06 11:58 ` Yao Qi
2017-11-06 16:39 ` Tom Tromey
2017-10-16 3:23 ` [RFA 4/4] Constify execute_command Tom Tromey
2017-10-16 3:23 ` [RFA 3/4] Constify add_setshow_* Tom Tromey
2017-10-16 3:23 ` [RFA 1/4] Constify add_info Tom Tromey
2017-11-05 16:52 ` [RFA 0/4] finish command constification Tom Tromey
2017-11-06 12:03 ` Yao Qi [this message]
2017-11-07 20:55 ` Tom Tromey
2017-11-08 9:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106120350.GC318@1170ee0b50d5 \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox