From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43837 invoked by alias); 6 Nov 2017 12:03:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43712 invoked by uid 89); 6 Nov 2017 12:03:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=anticipated, Hx-languages-length:882, H*r:sk:static., HContent-Transfer-Encoding:8bit X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Nov 2017 12:03:54 +0000 Received: by mail-wm0-f53.google.com with SMTP id y80so13233891wmd.0 for ; Mon, 06 Nov 2017 04:03:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nAOEXarhlspmfcaIo4ZJAZmnT9+yKrIIIfZKgfehFHo=; b=o3qZEdkgnXYdLRtp5wQqyzVaQ1Dbo2dFJCTU00sBcvlelhhzZl+Ix7BdBGeVQAEyeM BuFLAIlufM5nRawf45SiwOxz1xzOoII0rCpWK0qmTX4XpCuBBtvHgCCTkBFPYm9epCjd fq8uEjXUCr8G2s4CQHiZO8YkgO0VstJE48+I2insxLHdX8FBWQVE5+Gjnq5G6XlLtxdu crukGb4jBL6ZHuqGUhsYR5OMn+tfndMnIUv0TLyzwb6+qFtnjIEDNVTs/CBeLn2flrjD dFPhFaIvpDf1293lzYDcfbo7x124ZH0SOXQFr+Iwqbg7vXmx7axtsdJU2k5T5CLKq1MW 71nA== X-Gm-Message-State: AJaThX6TEqeAzo3QCwRADNXqDC/KUzcgSFch4B4/9kJ1pKUj7msqUQ0h RFxzhGnVagK+Dhkr9rgDGCU= X-Google-Smtp-Source: ABhQp+RppCXdeAMg3+n3s5sZVTRGC7YnhgoBye1TgqF5W3ygAF1xMdVc1XAzoHJqTejKoF/yzdTAzw== X-Received: by 10.28.199.75 with SMTP id x72mr5384315wmf.119.1509969832718; Mon, 06 Nov 2017 04:03:52 -0800 (PST) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id p28sm14477849wmf.2.2017.11.06.04.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 04:03:51 -0800 (PST) Date: Mon, 06 Nov 2017 12:03:00 -0000 From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 0/4] finish command constification Message-ID: <20171106120350.GC318@1170ee0b50d5> References: <20171016032239.24561-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171016032239.24561-1-tom@tromey.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00110.txt.bz2 On 17-10-15 21:22:35, Tom Tromey wrote: > This series completes my command constification efforts. This turned > out to be much simpler than I had anticipated; partly because I > started automating some of the changes, and partly because C++ makes > some incremental refactorings simpler -- as discussed before, in this > case by allowing the introduction of const overloads. Thanks for the efforts. > > This series touches some files I can't compile. I made a best effort > to inspect them for const correctness; but it's hard to be sure. > Given the experience of this series as a whole, I think it is safe to > say that any required changes will be minimal. I gave a comment about using x86_64-w64-mingw32 cross compiler to verify the changes in windows-nat.c. If the build is OK, this patch series is good to me. -- Yao (齐尧)