From: Tom Tromey <tom@tromey.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: Upgrading readline
Date: Sun, 30 Sep 2018 20:31:00 -0000 [thread overview]
Message-ID: <8736tqiv7q.fsf@tromey.com> (raw)
In-Reply-To: <83pnww5s1q.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Sep 2018 16:53:05 +0300")
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
Eli> The Readline version reportedly doesn't work with newer versions of
Eli> Windows, so I think we should ask upstream Readline to use the newer
Eli> code we have in GDB.
I sent a note to bug-readline with the patch.
>> I don't know the difference between __DJGPP__, __MSDOS__, and
>> __GO32__
Eli> They are all equivalent, so I suggest to change them all to use
Eli> __DJGPP__, unless there's some reason not to.
>> the sources also check __MINGW32__, _WIN32, and __CYGWIN__ at
>> places.
Eli> These are unrelated to DOS/DJGPP/GO32, they are for MinGW builds and
Eli> Cygwin builds.
When I did the merge, these changes disappeared, so maybe I was
misreading the diffs somehow. Or maybe I did the merge wrong, hard to
say.
What I did is make a new git repository and made a branch based on
readline 6.2 patch 1 -- the gdb base revision. Then I copied the
readline sources from the gdb repository on top of that and committed
it. Finally, I did a git merge from readline 7.0 patch 5 and fixed up
the conflicts.
You can see the resulting repository here:
https://github.com/tromey/gdb-readline/tree/gdb-readline
Future merges can be done this way pretty easily, either by just
recreating this process, or by cloning the repository and merging from
the latest readline.
readline 8 is in testing, so perhaps it would be good to try that to see
if there are any new readline bugs affecting gdb.
Tom
next prev parent reply other threads:[~2018-09-30 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 11:53 Tom Tromey
2018-09-29 13:53 ` Eli Zaretskii
2018-09-30 20:31 ` Tom Tromey [this message]
2018-09-29 18:20 ` Pedro Alves
2018-10-18 22:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736tqiv7q.fsf@tromey.com \
--to=tom@tromey.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox